Coder Social home page Coder Social logo

Comments (3)

dantman avatar dantman commented on April 28, 2024 1

As I'm developing an app more and more using React Navigation I'm strongly leaning towards modals (menus and dialogs) being something StackNavigator supports.

  • Handling menus and dialogs as part of params is insufficient. There are a variety of reasons one may want these separate, shared, or otherwise not polluting routes. And these grow as apps get bigger.
  • Because of my need for a Drawer, screens above the drawer, and a modal StackNavigator for full-screen dialogs I already have a terribly deep and convoluted route tree. And I can say for certain that having separate navigators to handle different types of routes just makes things more complicated than they need to be.

So rather than dialogs and modals being a separate navigator I think it's better for StackNavigator to be able to handle the key points of dialogs/menus/modals/overlays:

  • Routes that show the previous route in the stack below them.
  • Overlay routes that don't affect the header, and.
  • Routes that have a different transition style.

from react-navigation.github.io.

brentvatne avatar brentvatne commented on April 28, 2024

cc @ericvicenti - I tend to agree with @dantman's assessment here

from react-navigation.github.io.

ericvicenti avatar ericvicenti commented on April 28, 2024

I really think we should be careful about adding a million features to StackNavigator.. its already getting out of hand. I have more details on my thoughts here:

react-navigation/rfcs#15

from react-navigation.github.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.