Coder Social home page Coder Social logo

Comments (5)

DanielZlotin avatar DanielZlotin commented on May 19, 2024 1

Thanks for reporting, basically a duplicate of #36. closing to keep all discussions in 1 topic

from jsc-android-buildscripts.

ericketts avatar ericketts commented on May 19, 2024

The plot thickens -- if I force resolve the non intl flavor of android-jsc in my build.gradle config, not only does the above code block execute fine, but it appears that the (more complex) language i18n functionality also works properly, at least with ru-RU as the locale.

I've confirmed that the build.gradle was being respected by inspecting the JSC related .so files in the generated apk, and comparing the sizes against the known configuration build sizes; so I know that the intl and non-intl flavors haven't somehow become reversed... very puzzling behavior!

from jsc-android-buildscripts.

Kmakinator avatar Kmakinator commented on May 19, 2024

@ericketts is there any chance you can send me *.apk file where it actually works?

edit
Turning off intl just sets everything to en-US locale, instead of crashing with intl turned on...

from jsc-android-buildscripts.

ericketts avatar ericketts commented on May 19, 2024

@Kmakinator you'd like me to send you an apk built with the non-intl flavour? That's the only case where it works presently...

I'm happy to do that, but would need to put together a minimal repro (since the actual APK contains IP I cannot release), so want to make sure I understand you properly before spending the time creating the minimal repro...

from jsc-android-buildscripts.

ericketts avatar ericketts commented on May 19, 2024

So a bit more information, it turns out that unbeknownst to me, in the case of the non-intl flavored JSC being used, the Intl API was being polyfilled. If I prevent the polyfill from happening, everything is broken as you'd expect.

So this ticket now is solely about the intl flavor JSC failing when calling Intl.NumberFormat#format as outlined in the root comment.

from jsc-android-buildscripts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.