dragging working not correct about react-grid-layout

[jay0815]

@artem-malko here is my patch. [email protected]
I noticed that in the update from 1.4.3 to 1.4.4, commit #1323 added a calculation for the offset of containerPadding to the top and left properties, which affects the final position of the item. However, I found that calcXY already includes the handling of containerPadding.
Of course, this is a temporary solution, as it's just a rollback of that part of the calculation logic. Once I fully understand the entire logic of the position calculation, I might submit a PR to truly solve this issue.

[artem-malko]

@jay0815

By the way, if you set padding to [0, 0] — everything will work great)

[sikhaman]

@nlevos I also had thoughts to revert a version back, but want to wait an updates. I fixed issue by set up containerPadding={[0, 0]} as @jay0815 suggested. But this is just a patch, so waiting for the fixes and new version release

[jay0815]

I updated to version 1.4.4 and also encountered the same issue. Through debugging, I found that it was due to the changes in the logic for calculating top and left in #1323 . The key issue was caused by the containerPadding. I locally patched the previous version of the GridItem file to fix it.

[artem-malko]

@jay0815 hey, could you describe your patch? What did you do?

[jay0815]

@artem-malko hello,i have submitted a PR to fix the current bug.
In commit #1323, the author sought to correct an issue where ignoring the containerPadding attribute led to incorrect calculations of the final X/Y positions.
However, the fix was too simplistic and failed to take into account that, within the current library, the positions obtained during onDrag are already the outcome of calculations that incorporate the effects of both margin and containerPadding into the top and left values.
ContainerPadding is effectively equivalent to margin, because when containerPadding is not provided, margin is automatically used as the default for containerPadding. The reason why your provided containerPadding of [0,0] seems to work correctly is because, precisely at the [0,0] position, the calculation results from the current logic align with those from the correct calculation method.

[artem-malko]

@jay0815 thx a lot, will be waiting for review and release

[sikhaman]

have same issue, isBounded works very weird with or without paddings

[nlevos]

Hi guys, I have the same problem. On dragging the block moves by itself to position 0,0.
I reverted to v1.4.3 and it works as expected!

[MrZhouZh]

Have some issue, THX a lot.