fixture fails to enter fullscreen mode about react-cosmos

[noahehall]

will send a PR shortly

[skidding]

Hi @noahehall,

I'm not sure what the fullscreen functionality does in your app, but can you try something for starters: Can you open that fixture in full screen mode in Cosmos and see if you still get that error?

Basically press this button here and your fixture will break outside the Cosmos UI shell:

[skidding]

If you're calling the browser Fullscreen API – which I just found out about! – it seems like it only works inside an iframe that has the allow fullscreen on it: https://developer.mozilla.org/en-US/docs/Web/API/Element/requestFullscreen#usage_notes

Do you want to submit a PR to Cosmos to enable this functionality?

I think it's just a matter of allowing fullscreen on this iframe element:

react-cosmos/packages/react-cosmos-ui/src/plugins/RendererPreview/RendererPreview.tsx

Lines 35 to 41 in 0755897

	<Iframe
	data-testid="previewIframe"
	ref={onIframeRef}
	src={createRendererUrl(rendererUrl)}
	frameBorder={0}
	allow="clipboard-write *"
	/>

It already has clipboard-write * so combining both would result in "clipboard-write *; fullscreen *".

Please double check that this is the syntax for combining two allow values if you make this PR.

Thanks!

[noahehall]

Basically press this button here and your fixture will break outside the Cosmos UI shell:

didnt even know that existed, but yea it works when it breaks out of the cosmo shell

im going to try your fix for the iframe

[noahehall]

@skidding you were correct, adding fullscreen *; to the iframe permission set worked perfectly in chromium and firefox developer

[skidding]

@skidding you were correct, adding fullscreen *; to the iframe permission set worked perfectly in chromium and firefox developer

Cool! Will you submit a PR with that change?