Comments (9)
I checkout a new branch for 4.x to maintain: https://github.com/react-component/notification/tree/4.x
from notification.
I want to do it, but which branch should I develop on? It appears that the '5.x' version refactored this component. The problem is currently in version '4.x'!@zombieJ
from notification.
master
from notification.
master
The master branch should be '5.x' code, this version of the code does not have this problem, this problem should only appear in '4.x', should we upgrade the 'rc-notification' version to '5.0.0' in 'ant-design'? Or do we need a patch fix for version 4.x
notification/src/useNotification.tsx
Line 106 in fc89563
from notification.
a patch fix for version 4.x
Just send PR to master branch.
from notification.
a patch fix for version 4.x
Just send PR to master branch.
But the code in the 'master' branch has been refactored, there is no '4.x' related problem code, in the branch list, only '3.x' and 'master' to choose from, which branch should I use as a benchmark for development?
from notification.
mater 代码已经是 5.0-alpha 版本了,没有这个问题了,这个问题出现在 4.6 之前版本,如果 antd 后面更新 rc-notification 到最新版,就没有问题了。所以这个bug,是不是 antd 等更新,不用修复了?
from notification.
I checkout a new branch for 4.x to maintain: https://github.com/react-component/notification/tree/4.x
Great. I can fix it now
from notification.
https://github.com/react-component/notification/tree/v4.6.1
from notification.
Related Issues (20)
- closable 和 closeIcon 是不是没有用啊. 为什么我 传什么都是没有效果 HOT 1
- 建议:使用 useImperativeHandle hook 代替 ref callback HOT 2
- 删除updateKey后,引发的问题
- 建议允许传入ClassName HOT 1
- Unable to close notification since on release v4.5.0 HOT 6
- [Bug] simple demo-updatable
- Why it does't come to center? If there miss something? HOT 1
- 希望增加 props 可控 onMouseEnter onMouseLeave。
- CloseIcion not working
- How to use it with React 18 without warning HOT 1
- Not working with react 18 HOT 3
- Accessibility: making notifications visible to screen readers?
- Please update README for the hook verison notification. HOT 1
- Unable to close notification using the Enter key
- rc-notification v5 has no "export default", readme need to update HOT 1
- 请教下add()为什么要防止notice重复加入notices队列中 HOT 2
- index.d.ts为何没有提交npm
- 为什么我在nextjs里使用没有生效,只在控制台打印里close
- closeIcon overridden
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from notification.