Coder Social home page Coder Social logo

Comments (9)

afc163 avatar afc163 commented on June 26, 2024 1

I checkout a new branch for 4.x to maintain: https://github.com/react-component/notification/tree/4.x

from notification.

kiner-tang avatar kiner-tang commented on June 26, 2024

I want to do it, but which branch should I develop on? It appears that the '5.x' version refactored this component. The problem is currently in version '4.x'!@zombieJ

from notification.

afc163 avatar afc163 commented on June 26, 2024

master

from notification.

kiner-tang avatar kiner-tang commented on June 26, 2024

master

The master branch should be '5.x' code, this version of the code does not have this problem, this problem should only appear in '4.x', should we upgrade the 'rc-notification' version to '5.0.0' in 'ant-design'? Or do we need a patch fix for version 4.x

if (mergedConfig.key === null || mergedConfig.key === undefined) {

from notification.

afc163 avatar afc163 commented on June 26, 2024

a patch fix for version 4.x

Just send PR to master branch.

from notification.

kiner-tang avatar kiner-tang commented on June 26, 2024

a patch fix for version 4.x

Just send PR to master branch.

But the code in the 'master' branch has been refactored, there is no '4.x' related problem code, in the branch list, only '3.x' and 'master' to choose from, which branch should I use as a benchmark for development?

from notification.

HelloBojack avatar HelloBojack commented on June 26, 2024

mater 代码已经是 5.0-alpha 版本了,没有这个问题了,这个问题出现在 4.6 之前版本,如果 antd 后面更新 rc-notification 到最新版,就没有问题了。所以这个bug,是不是 antd 等更新,不用修复了?

from notification.

kiner-tang avatar kiner-tang commented on June 26, 2024

I checkout a new branch for 4.x to maintain: https://github.com/react-component/notification/tree/4.x

Great. I can fix it now

from notification.

afc163 avatar afc163 commented on June 26, 2024

https://github.com/react-component/notification/tree/v4.6.1

from notification.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.