Coder Social home page Coder Social logo

Comments (7)

redoxeon avatar redoxeon commented on August 23, 2024 1

I'm really new to rust, but I could maybe try this. I'm not quite understanding step 1 though. Is it already calling email_deliverable multiple times whenever it checks dilverability?

from check-if-email-exists.

amaury1093 avatar amaury1093 commented on August 23, 2024

Nice! That'd be great.

Is it already calling email_deliverable multiple times whenever it checks dilverability?

Yes exactly, it just means, at line 229 above, call the email_deliverable function multiple times. But we shouldn't create a new connection each time, just use the same smtp_client.

So step 1 is actually probably 90% of this issue, I'm not sure dividing it into 2 steps was actually clever 😄

from check-if-email-exists.

WaffleLapkin avatar WaffleLapkin commented on August 23, 2024

@redoxeon Have you done some progress implementing this yet?

Can I try to implement this feature?

Also, @amaurymartiny , do I understand you right, that all API that accepts params like to_email: &str, from_email: &str must now accept something like Vec<(&str, &str)>?

from check-if-email-exists.

amaury1093 avatar amaury1093 commented on August 23, 2024

that all API that accepts params like to_email: &str, from_email: &str must now accept something like Vec<(&str, &str)>

I was initially thinking to_email: Vec<&str>, from_email: &str (from_email is not really important), but yeah, Vec<(&str, &str)> is even more customizable.

from check-if-email-exists.

redoxeon avatar redoxeon commented on August 23, 2024

@WaffleLapkin I haven't gotten very far on this at all, so if you beat me at it, that'd be totally fine :)

from check-if-email-exists.

 avatar commented on August 23, 2024

hey,did you get around to implementing it?

from check-if-email-exists.

amaury1093 avatar amaury1093 commented on August 23, 2024

Nope, never implemented this. I guess this is a good hacktoberfest issue, if you want to tackle it.

from check-if-email-exists.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.