Coder Social home page Coder Social logo

Comments (5)

RubenVerborgh avatar RubenVerborgh commented on May 16, 2024 1

One usability issue: the built-in N-Triples parser would skip invalid lines. Many RDF dumps are invalid, and SERD just stops when this happens (without clear error message at the moment; would be useful to know which line is invalid). This means you'd have to correct the error and restart generation all over again.

That's not a real reason to keep the built-in parser though, because its definition of "invalid" was too narrow: it would happily parse some invalid IRIs, resulting in an invalid HDT file. At least with SERD, we know that the generated HDT file will be valid.

from hdt-cpp.

artob avatar artob commented on May 16, 2024

One minor bump in the road of removing the built-in N-Triples parser/serializer is that there are actually call sites in the code base that are hardcoded to use them, instead of cleanly going through a factory function that would encapsulate the multiple parser/serializer implementations.

For example, header parsing in src/header/PlainHeader.cpp is hardcoded to use the built-in parser. I'm working through these now.

from hdt-cpp.

artob avatar artob commented on May 16, 2024

This is overall a little bit of a larger task than we might have thought, since the varying reader/writer implementations aren't cleanly abstracted nor dispatched through a registry.

I think what I'll do is lift and adapt existing known-good code (that already abstracts over Serd and Raptor, and more) from our datagraph/librdf++ library (used in Dydra), and replace the I/O layer with that. That library also works on FILE handles, meaning that the transparent gzip (etc) compression code could be made to work with it more readily than with C++ iostreams.

from hdt-cpp.

RubenVerborgh avatar RubenVerborgh commented on May 16, 2024

Seems like a good idea, especially given the FILE handles thing.

from hdt-cpp.

RubenVerborgh avatar RubenVerborgh commented on May 16, 2024

Removed the built-in parser with bc7a258 and 09a1e6b because people kept hitting this issue (LinkedDataFragments/Client.js#26, LinkedDataFragments/Server.js#37, …).

from hdt-cpp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.