Coder Social home page Coder Social logo

Comments (5)

bernhardh avatar bernhardh commented on July 29, 2024 2

If you make that change then you'd have to require twig >= 3.9.0 because the CoreExtension::getAttribute() isn't present in older twigs.

Yes. But if you wanna keep backward compatibilty, just do:

if (! function_exists("twig_get_attribute")) {
    function twig_get_attribute(
        $env,
        $source,
        $object,
        $item,
        $arguments,
        $type,
        $isDefinedTest,
        $ignoreStrictCheck,
        $sandboxed,
        $lineno
    )
    {
        return \Twig\Extension\CoreExtension::getAttribute(
            $env,
            $source,
            $object,
            $item,
            $arguments,
            $type,
            $isDefinedTest,
            $ignoreStrictCheck,
            $sandboxed,
            $lineno);
    }
}

This works btw as a hotfix as well until this packages gets an update ;)

from twigbridge.

barryvdh avatar barryvdh commented on July 29, 2024 1

So we just have to replace that call with \Twig\Extension\CoreExtension::getAttribute right?

from twigbridge.

barryvdh avatar barryvdh commented on July 29, 2024 1

Fixed in https://github.com/rcrowe/TwigBridge/releases/tag/v0.14.3

from twigbridge.

barryp avatar barryp commented on July 29, 2024

Seems like it.

I was just now looking for other twig_*() functions that TwigBridge was calling and didn't find any.

If you make that change then you'd have to require twig >= 3.9.0 because the CoreExtension::getAttribute() isn't present in older twigs.

from twigbridge.

uandco avatar uandco commented on July 29, 2024

Faced the same issue, the workaround is to add that extra twig dependency at the root level instead of relying on TwigBridge to require it with the too broad ~3.0, while TwigBridge's own requirement is fixed.

from twigbridge.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.