Coder Social home page Coder Social logo

Comments (8)

RazrFalcon avatar RazrFalcon commented on August 17, 2024

The Document internals should not be public. Why do you need them?

A simple fix is to pub use dom::*; in src/lib.rs.

There are no docs there, so it's not that simple =)

from resvg.

dylanede avatar dylanede commented on August 17, 2024

Well, Document contains Elements publicly, but this type is not made public, nor are the types used by the transitive public members of Element.

from resvg.

RazrFalcon avatar RazrFalcon commented on August 17, 2024

It's because you shouldn't use them outside the backend code. The Document is just a container of SVG data. You should not care about what inside. You can treat it as an opaque pointer.

from resvg.

dylanede avatar dylanede commented on August 17, 2024

In that case you should probably make the members of Document pub(crate) instead of pub.

Though if someone wanted to use the document processing capabilities of resvg for writing their own SVG renderer, making these things public would be very handy (i.e. that's what I'm doing right now, with a fork making these types public).

from resvg.

RazrFalcon avatar RazrFalcon commented on August 17, 2024

Hm... The idea is the backend code should be inside the library. But if you want to use it just as preprocessor (all backend are optional already), then yes - it will be handy.

I will make them public and add docs and Debug.

from resvg.

dylanede avatar dylanede commented on August 17, 2024

Thanks!

from resvg.

RazrFalcon avatar RazrFalcon commented on August 17, 2024

Done. Documentation is pretty simple, but I hope it help.

from resvg.

dylanede avatar dylanede commented on August 17, 2024

Thanks again

from resvg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.