Coder Social home page Coder Social logo

Comments (3)

adamreichold avatar adamreichold commented on September 3, 2024

From the man page

MAP_LOCKED (since Linux 2.5.37)
              Mark  the mapped region to be locked in the same way as mlock(2).  This implementation will try to populate (prefault) the whole range but the mmap() call doesn't fail with ENOMEM if this fails.  Therefore major faults might happen later on.  So the
              semantic is not as strong as mlock(2).  One should use mmap() plus mlock(2) when major faults are not acceptable after the initialization of the mapping.  The MAP_LOCKED flag is ignored in older kernels.

Since it can fail silently, maybe it would be better to provide only lock and unlock methods and ignore the flag?

Otherwise, it should be handled just like MAP_POPULATE IMHO.

What I wondered about in the initial PR is whether can have at least some tests for the lock/unlock functionality. What is resource limit for locking memory in GitHub actions? Would that be sufficient for a small test case?

from memmap2-rs.

vmx avatar vmx commented on September 3, 2024

Since it can fail silently, maybe it would be better to provide only lock and unlock methods and ignore the flag?

That sounds like a good idea.

Do I understand the mmap documentation correctly, that if I would want to have a similar to the MAP_LOCKED flag, I'd call populate() and the mlock()? That should work for my use case (populate() wasn't a thing at the time of the fork).

So I'll do a PR with lock() and unlock() only (I guess the names should be without the leading "m", just as advise()).

I wanted to do a test, but I couldn't think of a way to do it. How would I test that a page is actually locked? Did you think of creating a lock of a mmap that is bigger than the available memory which then should fail as it won't swap?

from memmap2-rs.

adamreichold avatar adamreichold commented on September 3, 2024

Do I understand the mmap documentation correctly, that if I would want to have a similar to the MAP_LOCKED flag, I'd call populate() and the mlock()? That should work for my use case (populate() wasn't a thing at the time of the fork).

From the man page

  mlock(), mlock2(), and munlock()
       mlock()  locks pages in the address range starting at addr and continuing for len bytes.  All pages that contain a part of the specified address range are guaranteed to be resident in RAM when the call returns successfully; the pages are guaranteed to stay
       in RAM until later unlocked.

I would assume that MAP_POPULATE is not even necessary.

I wanted to do a test, but I couldn't think of a way to do it. How would I test that a page is actually locked? Did you think of creating a lock of a mmap that is bigger than the available memory which then should fail as it won't swap?

I was thinking about having the test make the system calls without errors would be helpful already. Theoretically /proc/self/smaps could be checked to determine if the range is locked into memory, but I think that might be a bit too much (and too specific to Linux).

from memmap2-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.