Comments (5)
It was discussed already here: #10
Basically my point was the the caller should omit memmap dependency on their side. Using feature flags.
std is kinda an exception here and I'm not sure what is the best solution.
from memmap2-rs.
Basically my point was the the caller should omit memmap dependency on their side.
As someone who doesn't directly depend on memmap2
, that's not really a workable solution. I'll also say that not having build support for these platforms, I'm far likely to move away from any dependency that uses memmap2
entirely, than I am to go change my dependency's to cfg
it out.
std is kinda an exception here and I'm not sure what is the best solution.
If std
is the exception (I don't think it is, both windows
, and winapi
compile on Linux just fine despite their APIs having zero support for it), then it is the exception that proves the rule, that people expect people expect crates to be cross-compiliation friendly even when there isn't run-time feature support.
from memmap2-rs.
people expect crates to be cross-compiliation friendly even when there isn't run-time feature support
Is it stated/specified somewhere? I don't know many crates like this, so I don't know what is the default behaviour here.
Overall, I guess we can simply merge #10 and that's it.
from memmap2-rs.
Is it stated/specified somewhere? I don't know many crates like this, so I don't know what is the default behaviour here.
No, it's not an explicit requirement anywhere, but I believe it is an implicit expectation that has built up around Rust crates, following the example of crates like std
, and the ease at which you can build and test for other platforms in Rust. I would say generally that most platform specific crates I've encountered in the wild include some amount of stub code for others platforms that users wanted to compile it for.
Aside from the two I already mentioned, other examples of this include num_cpus
and libc
where the platform details are entirely isolated inside the crate. Even though there's no way to query the CPU or access libc
on WebAssembly, you can still compile and use both in WASM.
from memmap2-rs.
Thank you for fixing this!
from memmap2-rs.
Related Issues (20)
- Migrate to `safer_owning_ref` HOT 1
- why does memmap2::Mmap::map need to be unsafe? HOT 4
- Implement AsRawFd, IntoRawFd, AsRawHandle, IntoRawHandle and Into<Stdio> for MMap HOT 2
- Composite memory maps currently impossible HOT 7
- mmap'd anon pages fail in io_uring IOSQE_BUFFER_SELECT usage HOT 2
- advise_writes_unsafely_to_part_of_map test fails on powerpc64le-unknown-linux-gnu HOT 2
- error[E0433]: failed to resolve: could not find `Advice` in `memmap2` HOT 1
- PermissionDenied, message: "Access is denied." at remove file after read on Github Action WIndows HOT 2
- Doesn't compile for freebsd HOT 3
- v0.9.2 build failed for android target. HOT 3
- Support for `MS_INVALIDATE`? HOT 8
- Mac osx support HOT 1
- Support `mremap(2)` HOT 1
- Mapping beyond 4GB offset if broken on 32 bit glibc (Linux) HOT 3
- Support multiple advice HOT 2
- Contributing a migration from rustix to libc HOT 9
- MSRV and edition HOT 5
- Merging changes with memmapix HOT 24
- memmap2 `advise` is unsound HOT 8
- Interest is supporting mbind HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from memmap2-rs.