Comments (2)
Hey @st-clair-clarke thanks for bringing this up and putting in the work to give all the details!
The isEmpty
function is one I implemented to reach enough parity with Lodash so I could convince a team to use radash as a Lodash replacement. Now that I think about it, we ended up dumping isEmpty
completely for a better solutions all together so this function has been unused AFAIK personally.
I'll mark this as a bug and get it fixed asap 🚀
from radash.
@st-clair-clarke just put up a PR to fix this. I went through your test cases and replicated them. The only one I'm not sure about is the Date tests. Logically, I agree with your test case that a valid Date
object should be not-empty. I was validating these against Lodash and noticed they return true for any Date
object...
Not that I care too much about what Lodash does. To be honest, I'm not sure what the implications are for other people trying to use radash. Specifically, those trying to directly replace Lodash with Radash.
from radash.
Related Issues (20)
- why not provide deep copy method,be like deep copy of array or object? HOT 7
- Incorrect Return Value for isObject(Object.create(null)) HOT 3
- Ts type error in 'shake'
- construct sometimes converts integers with letters into an array instead of an object
- can't open `Edit this page on GitHub` in docs
- AggregateError cannot be used with `instanceof` HOT 3
- We need Chinese documents HOT 5
- Why is cloneDeep not implemented HOT 2
- Feature Request: Convert flat array objects to tree-like data
- crush behaves unexpectedly HOT 1
- Similar to `objectify`, to return `Map` HOT 4
- [Async] Allow onRetry option for retry HOT 1
- isNumber(NaN)
- allow debounce to trigger on leading (and trailing) edge HOT 3
- `isObject` should not be used by other functions in radash HOT 1
- debounce 函数在vue3 选项式api中使用存在this指向问题
- [REQUEST] assign - How to keep object references
- [Array] toggle with falsy elements returns wrong result HOT 1
- `isPromise` misleading in type definitions, it should return `value is PromiseLike<>` HOT 1
- [Request] Loosen the type on the Array sum function HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from radash.