Coder Social home page Coder Social logo

Comments (2)

sodiray avatar sodiray commented on August 20, 2024

Hey @st-clair-clarke thanks for bringing this up and putting in the work to give all the details!

The isEmpty function is one I implemented to reach enough parity with Lodash so I could convince a team to use radash as a Lodash replacement. Now that I think about it, we ended up dumping isEmpty completely for a better solutions all together so this function has been unused AFAIK personally.

I'll mark this as a bug and get it fixed asap 🚀

from radash.

sodiray avatar sodiray commented on August 20, 2024

@st-clair-clarke just put up a PR to fix this. I went through your test cases and replicated them. The only one I'm not sure about is the Date tests. Logically, I agree with your test case that a valid Date object should be not-empty. I was validating these against Lodash and noticed they return true for any Date object...

Not that I care too much about what Lodash does. To be honest, I'm not sure what the implications are for other people trying to use radash. Specifically, those trying to directly replace Lodash with Radash.

Screen Shot 2022-08-31 at 8 36 44 PM

from radash.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.