Coder Social home page Coder Social logo

Comments (3)

rawilk avatar rawilk commented on May 27, 2024

Thanks for pointing that out. I've released version 3.0.6, which doesn't use the strict comparison anymore to determine if the option is selected.

from laravel-form-components.

xorock avatar xorock commented on May 27, 2024

I see a small problem here. Very often in the search form there are 3 fields for the select element e.g.: null => All, 0 => No, 1 => Yes. These fields map directly to the database, to some boolean type. Unfortunately, in php

var_dump(0 == null); // true

The loose comparison results in two options being checked incorrectly

<select class="form-text form-select" name="filterx" id="filterx">
                    <option value="" selected="">
        All
    </option>
                    <option value="0" selected="">
        No
    </option>
                    <option value="1">
        Yes
    </option>
    </select>

The Laravel Collective library takes additional things into account here: https://github.com/LaravelCollective/html/blob/6.x/src/FormBuilder.php#L1299

Maybe You can also consider this fix here?

from laravel-form-components.

rawilk avatar rawilk commented on May 27, 2024

I don't think that should be an issue with v8 of this package, but I'd keep an eye on it. If it becomes an issue for you, feel free to raise an issue on it.

from laravel-form-components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.