Coder Social home page Coder Social logo

Comments (3)

lurch avatar lurch commented on August 22, 2024 1

Hah, just took me about 10 minutes to see what the difference was!! 😆 🔍
In the version at https://github.com/raspberrypi/pico-examples/blob/develop/picoboard/blinky/blinky.c it's using < 'z' but it should be <= 'z' - which we obviously didn't notice ourselves because the example "Hello world" string doesn't contain a z.
Thanks for spotting this, I'll submit a PR...

from pico-examples.

lurch avatar lurch commented on August 22, 2024

This can be closed now @kilograham

from pico-examples.

lurch avatar lurch commented on August 22, 2024

@kilograham Ahhhh, so this is why issues aren't being closed when the associated PR is merged:

Note: The special keywords in a pull request description are interpreted when the pull request targets the repository's default branch. However, if the PR's base is any other branch, then these keywords are ignored, no links are created and merging the PR has no effect on the issues.

Looks like there's a 3rd-party "action" to get around that, if this behaviour becomes too annoying https://github.com/marketplace/actions/closes-issues-related-to-a-merged-pull-request
(but I dunno the security implications of giving a 3rd-party addon access to secrets.GITHUB_TOKEN )

from pico-examples.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.