Comments (3)
Hah, just took me about 10 minutes to see what the difference was!! 😆 🔍
In the version at https://github.com/raspberrypi/pico-examples/blob/develop/picoboard/blinky/blinky.c it's using < 'z'
but it should be <= 'z'
- which we obviously didn't notice ourselves because the example "Hello world"
string doesn't contain a z
.
Thanks for spotting this, I'll submit a PR...
from pico-examples.
This can be closed now @kilograham
from pico-examples.
@kilograham Ahhhh, so this is why issues aren't being closed when the associated PR is merged:
Note: The special keywords in a pull request description are interpreted when the pull request targets the repository's default branch. However, if the PR's base is any other branch, then these keywords are ignored, no links are created and merging the PR has no effect on the issues.
Looks like there's a 3rd-party "action" to get around that, if this behaviour becomes too annoying https://github.com/marketplace/actions/closes-issues-related-to-a-merged-pull-request
(but I dunno the security implications of giving a 3rd-party addon access to secrets.GITHUB_TOKEN
)
from pico-examples.
Related Issues (20)
- Make sure there's an example of using stdio_set_chars_available_callback HOT 2
- Flashing pico fails HOT 4
- Add example of using TinyUSB CDC with extra stdio_usb iface
- Modify the pio uart examples to use DMA HOT 1
- ping examples hardcode an IP address
- Recommended launch.json is slow to connect due to no "adapter speed" setting
- No key press detected for pending in [iperf server] example HOT 1
- stdio_usb input available callback can't call other stdio functions, and pico-examples iperf assumes it can. HOT 4
- UART RX Garbage data recived HOT 5
- Pico-W to Pico-W STALL while sending UDP HOT 2
- Bug in BME280 SPI example when reading compensation parameters for humidity HOT 3
- Out-of-Memory Errors When Publishing MQTT Messages HOT 1
- host_cdc_msc_hid: incorrect len parameter in tuh_hid_report_received_cb HOT 1
- Bug in pio/uart_rx /uart_rx_intr.c HOT 6
- ir_nec variable length commands HOT 8
- How to do multiple TLS requests with changing request string HOT 2
- Example of starting and stopping btstack needed
- What does example iperf.c HOT 11
- Why MEMP_NUM_ARP_QUEUE lwIP options is set in lwipopts_examples_common.h if ARP_QUEUEING default value is 0? HOT 1
- Modbus TCP client over Wifi for Raspberry Pi Pico W (RP2040) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pico-examples.