Coder Social home page Coder Social logo

Add a `pyproject.toml` about mlxtend HOT 4 CLOSED

jmahlik avatar jmahlik commented on May 27, 2024
Add a `pyproject.toml`

from mlxtend.

Comments (4)

jmahlik avatar jmahlik commented on May 27, 2024

I also noticed the package is importing itself to find the version. Which makes installing from an sdist not possible (the package isn't yet installed when installing itself).

The warning at the very bottom: https://packaging.python.org/en/latest/guides/single-sourcing-package-version/

I'll adjust that in the pr as well.

from mlxtend.

rasbt avatar rasbt commented on May 27, 2024

Thanks a lot for opening this issue. Actually, moving to .toml for my packages has been something on my list for quite some time, but I never had the time to get to it. If you could open a PR that would be really appreciated!

from mlxtend.

jmahlik avatar jmahlik commented on May 27, 2024

Thanks a lot for opening this issue. Actually, moving to .toml for my packages has been something on my list for quite some time, but I never had the time to get to it. If you could open a PR that would be really appreciated!

Awesome! I opened a PR with the basics of specifying a build system and got the install working from an sdist for now.

I'd be willing to work on migrating the configs from the setup.py over to the pyproject.toml. Think it might require some work/discussion about how to handle the version. Right now it's dynamic from the module. I can start on another PR to migrate it fully.

from mlxtend.

rasbt avatar rasbt commented on May 27, 2024

@jmahlik I forgot to mention that I made a new PyPI release a few days ago. Thanks again for the PR restructuring this package to finally use .toml!!

from mlxtend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.