Coder Social home page Coder Social logo

Comments (6)

RaphiMC avatar RaphiMC commented on July 2, 2024 1

I am now "redirecting" the call inside the render method. I use mixins extras for that so it will be compatible with other mods redirecting it as well

from immediatelyfast.

unascribed avatar unascribed commented on July 2, 2024

You don't even give me 3 seconds to test this for myself before reporting it to the other party. It's unlikely ImmediatelyFast is doing anything wrong.

from immediatelyfast.

unascribed avatar unascribed commented on July 2, 2024

Reproduced with Lucium (the mod I told you Yttr includes that would cause this, and not Yttr itself), looking into it.

from immediatelyfast.

unascribed avatar unascribed commented on July 2, 2024

Disabling this mixin fixes it: https://github.com/RaphiMC/ImmediatelyFast/blob/1.19.3/src/main/java/net/raphimc/immediatelyfast/injection/mixins/batching/MixinDebugHud.java

So for some reason batching the debug hud is breaking Lucium's debug hud rework.

I'll take ownership and responsibility of this; please close.


EDIT: A mixin export makes it quite obvious why this happens:

image

The batch is never ended due to the way the mixins order. I'll add a call into endBatching in my code.

from immediatelyfast.

RaphiMC avatar RaphiMC commented on July 2, 2024

This is actually an issue in ImmediatelyFast. I intended for the mixins to order in such a way that my mixins are applied last and thus inject before the return instruction your mixin added. But mixins doesn't seem to work that way. I will fix it differently on my side as well

from immediatelyfast.

unascribed avatar unascribed commented on July 2, 2024

It's not possible to inject before another mod's cancel in that way. You would hope and wish that RETURN matches other injects, but it just doesn't.

The best you would be able to do is inject before Lucium's entire inject, but that won't help either.

from immediatelyfast.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.