The sample code in the read-me is missing a ps.dispose() call in the success case about child-shell

[mklement0]

Note that https://rannn505.gitbook.io/node-powershell/start again shows ps.dispose(), and only in the .catch() call, again inviting confusion.

If the intent is to show that the process remains open to service more commands later, at least a comment is called for.

[BenjaminMichael]

Makes sense for the readme example but starting out I actually found the opposite more confusing when working on anything nontrivial. Basically any time I have used node-powershell I have used the object for more than one PS command invocation and not disposing the object is much much faster than creating a new object every time. I don't find that I need to dispose of the object on errors either.

[mklement0]

@BenjaminMichael:

It is crucial that sample code work as-is, so as not to confuse beginners.

• If there's a better - and concise - way to make sure the success case finishes processing, fix the sample to show that. (I can't tell, because the docs are broken, and I don't want to tinker with my browser's security settings just to make them work).

• Otherwise, use the simple ps.Dispose() approach and add comments or notes pointing to more advanced information.

[rannn505]

removed the dispose from both as I want people to understand that the process is still open.