Coder Social home page Coder Social logo

Comments (6)

Andrei-Pozolotin avatar Andrei-Pozolotin commented on June 23, 2024

@m50d

  1. please verify fix in fresh 1.4.0:
    https://bintray.com/random-maven/maven/scalor-maven-plugin_2.12
  2. working project example for reference:
    https://github.com/random-maven/scalor-maven-plugin/blob/develop/demo/pom.xml#L240
    https://github.com/random-maven/scalor-maven-plugin/blob/develop/demo/pom.xml#L316
  3. a way to test is:
  • delete ${project.basedir}/.settings/...
  • issue from menu: ${project} -> Maven -> Update Project ...

from scalor-maven-plugin.

m50d avatar m50d commented on June 23, 2024

I can't find any way to confirm whether the ascii names have actually been applied in 2.12 - both scalap and the -Xprint:kind-projector parameter print with the parameters used in type lambdas as ?$0$ etc.. I remember previous versions of scala behaving differently but can't now reproduce. Suggest treating this as fixed? Sorry I didn't think through my use case thoroughly enough.

from scalor-maven-plugin.

Andrei-Pozolotin avatar Andrei-Pozolotin commented on June 23, 2024
  1. try to view with http://jd.benow.ca/
  2. try to access expected generated member via reflection
  3. post a minimal working project somewhere so I can take a look

from scalor-maven-plugin.

m50d avatar m50d commented on June 23, 2024

I don't think the generated type names exist at all in the Java bytecode - see https://github.com/non/kind-projector#under-the-hood for the kind of code that gets generated, the type Λ is entirely gone at runtime. I can link a minimal project with kind-projector set up and running if you want, but I can't find any way to distinguish whether it was using ascii names or not.

from scalor-maven-plugin.

Andrei-Pozolotin avatar Andrei-Pozolotin commented on June 23, 2024
  1. the following test:

https://github.com/random-maven/scalor-maven-plugin/blob/develop/demo/src/macro/scala/meta/MacroBundle.scala#L19

https://github.com/random-maven/scalor-maven-plugin/blob/develop/demo/src/macro/scala/meta/Macro.scala#L17

https://github.com/random-maven/scalor-maven-plugin/blob/develop/demo/src/main/scala/kind/SystemProperty.scala#L11

https://github.com/random-maven/scalor-maven-plugin/blob/develop/demo/src/test/scala/kind/SystemPropertyTest.scala#L14

  1. shows both in Maven and Eclipse
Running kind.SystemPropertyTest
property=null
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.292 sec - in kind.SystemPropertyTest
  1. meaning that -D options are not propagated by compiler,
    at least in macro context, although it still may work in plugin context

  2. since suggested way to alter plugin behavior is -P
    you may want send PR to https://github.com/non/kind-projector
    i.e. -P:scalajs:sjsDefinedByDefault
    https://www.scala-js.org/doc/interoperability/sjs-defined-js-classes.html
    and also use some logging to verify options activation

from scalor-maven-plugin.

Andrei-Pozolotin avatar Andrei-Pozolotin commented on June 23, 2024

resolved https://github.com/random-maven/scalor-maven-plugin/releases/tag/1.4.0.20180329174003

from scalor-maven-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.