Coder Social home page Coder Social logo

Comments (7)

ramsey avatar ramsey commented on May 26, 2024 1

Thanks for reporting back your findings. I'll need to look into this. It does make sense that it should respect the current working directory of the job.

from composer-install.

Kocal avatar Kocal commented on May 26, 2024

Hi, see https://github.com/ramsey/composer-install#alternate-composerjson-locations.

Using --workding-dir in your composer-options will automatically change the working directory (see related PR #107)

from composer-install.

jbelien avatar jbelien commented on May 26, 2024

Yes, that works indeed perfectly fine.

My question was about not having to specify --workding-dir in my composer-options if defaults.run.working-directory is specified.
Am I missing something ?

from composer-install.

ramsey avatar ramsey commented on May 26, 2024

This is fixed in v2, please upgrade using ramsey/composer-install@v2 or ramsey/[email protected]. Details are available on the release announcement and the README.

Thanks!

from composer-install.

jbelien avatar jbelien commented on May 26, 2024

Thanks a lot @ramsey ! 👍

Will it work with defaults.run.working-directory (default configuration) or do I still need to specify working-directory as input ?

from composer-install.

ramsey avatar ramsey commented on May 26, 2024

Hmm. That's a good question. If defaults.run.working-directory tells GitHub to run everything from that directory, it should work accordingly, as long as your composer.json isn't in some place other than defaults.run.working-directory. Let me know if it doesn't work.

from composer-install.

jbelien avatar jbelien commented on May 26, 2024

Hmm. That's a good question. If defaults.run.working-directory tells GitHub to run everything from that directory, it should work accordingly, as long as your composer.json isn't in some place other than defaults.run.working-directory. Let me know if it doesn't work.

I just tried and it doesn't work if I just specify defaults.run.working-directory

Error: Unable to find composer.json at './composer.json'

I tried stuff like the following but it doesn't seem to be "supported" by GitHub Actions.

- uses: ramsey/composer-install@v2
  with:
    working-directory: ${{ defaults.run.working-directory }}

But using working-directory with the correct path in ramsey/composer-install@v2 works as expected! 👍

from composer-install.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.