Coder Social home page Coder Social logo

Comments (5)

rakhimov avatar rakhimov commented on June 11, 2024

Catch is provided as git submodule (may have custom patches).
It is currently not meant to work with the system catch.
You are circumventing it with sed.
The pristine version should have failed with BUILD_TESTING=ON

from scram.

rakhimov avatar rakhimov commented on June 11, 2024

Wsign-compare warning is because of the pesky 'size_t' being unsigned.
I don't bother dealing with this language annoyance.
http://www.aristeia.com/Papers/C++ReportColumns/sep95.pdf

from scram.

Vascom avatar Vascom commented on June 11, 2024

It is not simple for fedora packaging to use git submodules. So I disable tests.
And will wait 0.17.0 release.

from scram.

rakhimov avatar rakhimov commented on June 11, 2024

It is not simple for fedora packaging to use git submodules. So I disable tests.

I have been also disabling tests in packaging for this reason (Fedora, Debian, Arch, mac, win).

I am not very familiar with Fedora packaging conventions, but
IMHO unit/integration/etc. tests could be omitted in distro packaging anyway.
Tests that verify the installation/setup should suffice (smoke tests mostly).
For example,

scram --help
scram-gui --help
scram --version
scram /path/to/share/scram/input/TwoTrain/two_train.xml

Can this be acceptable for Fedora?

from scram.

Vascom avatar Vascom commented on June 11, 2024

I am enable tests because I not use scram and this is only way for me to test builded binary. It is normal not enable tests during package build.

from scram.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.