Problem about show "Backend menu" about builder-plugin

[alekseybobkov]

Do you mean that a menu item is not shown although the user is allowed to see it?

[vmdao]

Yes! User is allowed not see.

[alekseybobkov]

I can't replicate the problem. Please make sure that you use latest version of the Builder and core. Submit steps for replicating the problem. If you can - please create a new plugin and attach it as a ZIP file here.

[vmdao]

Ok, I uploaded google driver
https://drive.google.com/folderview?id=0B3lfds0CCdr7OFZFLWk4aUVxcVk&usp=sharing

[vmdao]

@alekseybobkov, Can you look problem?

[alekseybobkov]

I can't confirm the problem. I can see the menu item under the administrator user account and it's expected. When I sign in as another user, I don't see the menu item because the user doesn't have the corresponding permission.

[ametad]

I too have a similar problem; hopefully this adds positively to the conversation. With Builder I first create permissions. Then I have set the permissions for backend menus to my controllers in the plugin.

Example, define the permission:

Then use it for menu:

(the companyname is deliberately crossed)

When a user now gets the permission to '..test.access_test' the menu is NOT shown! When I remove the permission from the menu or when I make the user a superuser; the menu is shown again.

Do I perhaps forget a step or something?

[alekseybobkov]

I still can't reproduce it. That's how I test:

• Install a test plugin from #51 (comment) (I had to remove updates to not pollute my database).
• Go to Settings / Administrators.
• Assign "Allow" value to Other Brands / Manage Orders permission for a test administrator.
• Log in as the test administrator.
• Make sure that I see the Manage Orders menu item.

If I change "Allow" to "Deny" I don't see the menu item.

[ametad]

Thank you for your response!

I will try the same test plugin as you did, with the same steps and report back.

What do you mean with: "I had to remove updates to not pollute my database". What updates exactly, or does this not concern anyone else you think?

[ametad]

Perhaps you mean this:

Rolled back: Daovm.OrderBrand
Reinstalling plugin...
PHP Fatal error: Cannot declare class Daovm\OrderBrand\Updates\BuilderTableUpdateDaovmOrderbrandOrder4, because the nam
e is already in use in /home/vagrant/Code/ubpweb2/plugins/daovm/orderbrand/updates/builder_table_update_daovm_orderbrand
_order_4.php on line 17

I did a little renaming so that the updates runs just fine.

[ametad]

My test fails unfortunately. The results (if you miss something, please just ask):

This will test the permissions of another administrator then the account I am logged in; for "Manager Orders" are allowed and denied, to see if the menu items appear.

The other account settings:

Permission "Allow":

The account belongs to the "Owners" group, the permission for "Manager Orders" in the group is not selected.

Now to test the appearance of the menu item, I log into the backend with this other administrator account: the menu item is NOT shown:

But with...

The menu item is shown correctly:

[ametad]

Could this perhaps be a caching / cookie problem..?

[ametad]

Some more testing data: I have tested if the controller/action is available for the logged in non-super-user, by going to that url (backend/daovm/orderbrand/orders):

Permission 'daovm.orderbrand.manager_order' for user:

• denied: access is denied (as intended!)
• allowed: access is allowed and the page is shown (as intended!)

The only thing that is not correctly working is showing the menu items, accordingly to the permissions set.

[ametad]

Deeper into the code of October we dive...

Dump in \Backend\Classes\NavigationManager registerMenuItems()
of $owner and $definitions:

"Daovm.OrderBrand"

array:1 [▼
  "manager_orders" => array:5 [▼
    "label" => "Manager Orders"
    "url" => "http://localhost/backend/daovm/orderbrand/orders"
    "icon" => "icon-bookmark"
    "permissions" => array:1 [▼
      0 => "http://localhost/backend/daovm.orderbrand.manager_order"
    ]
    "sideMenu" => array:1 [▼
      "orders" => array:4 [▼
        "label" => "Orders"
        "url" => "http://localhost/backend/daovm/orderbrand/orders"
        "icon" => "icon-ticket"
        "permissions" => array:1 [▼
          0 => "http://localhost/backend/daovm.orderbrand.manager_order"
        ]
      ]
    ]
  ]
]

"October.Backend"

array:1 [▼
  "dashboard" => array:5 [▼
    "label" => "backend::lang.dashboard.menu_label"
    "icon" => "icon-dashboard"
    "url" => "http://localhost/backend/backend"
    "permissions" => array:1 [▼
      0 => "backend.access_dashboard"
    ]
    "order" => 1
  ]
]

The "permissions" are way different. Is this maybe a problem?

[alekseybobkov]

@ametad, please make sure that you're running the latest build of October. There was an issue #30, which is already fixed, where URLs were applied to permissions.

[ametad]

Thank you for pointing that out. Once updated correctly the problem is gone! Permissions and the showing/hiding of menu's works correctly.