[bug] MetaMask WalletButton does not target MetaMask when competing injected providers set (e.g. Phantom) about rainbowkit

[magiziz]

@guyton-cb I can reproduce this on my end. This is happening because rabby wallet overrides metamask. This is happening for many wallets like zerion, coinbase and others. Let me quickly see if i can get a quick fix and get back to you.

[guyton-cb]

Make sense to me. I actually ran into this exact same issue building my own connect flow using wagmi, it's what lead me to try out Rainbowkit to see if yall had a fix with custom btns.

For now, Ill use the connect modal. Thanks!

[magiziz]

There are some cases where EIP-1193 wallets are overriding each other, but it doesn't seem like it's doing nothing. At least when i have Phantom and MetaMask enabled:

Can you please share a small repro example with code ?

[guyton-cb]

I assume the Wallet Buttons on the docs page is implemented the same on the example app https://rainbowkit-example-rainbowdotme.vercel.app/

Some times it works for me on the docs site, and some times stalls. In the cases where i have only MM/Phantom it works fine on the docs site but not when i use a Custom WalletButton. I am currently debugging now to get more insights.

Current setup:

• install 3 wallets: rabby, metamask, phantom
• rabby is set MetaMask is in use and Rabby is banned
• clicking MM does nothing

[magiziz]

@guyton-cb Just found out that this one seems to be out of our control. Rabby wallet appends it's own data and overrides MetaMask's data / functions.

This is very normal since a lot of these wallets do the same thing, but we can ignore some of them and not all of them. RainbowKit v1 also has faced with the same issue until we've introduced EIP-6963 to the connect modal, we'll eventually do the same thing for WalletButton.

Meanwhile what i would suggest doing is using our connect modal since it does provide support for EIP-6963 like Rabby and MetaMask, but you might get the same issue just very rare.

Hopefully this makes sense and we're just a wrapper around wagmi so this is something that's out of our control and the best thing you can do is not have your Rabby wallet enabled by the time your connecting your wallet.

Lmk if this is makes sense 🙏

[magiziz]

@guyton-cb Gotcha. Yeah lmk if you face any other issues, but we'll support EIP-6963 for WalletButton near future after wagmi fixes some stuff on their end.