Coder Social home page Coder Social logo

Comments (5)

DanielSinclair avatar DanielSinclair commented on May 24, 2024 3

@SyedAhkam To clarify, the wallet you added is still available, it is just moved to an Installed list at the top, because it is detected as installed by the new EIP-6963 connection standard. This is how Wagmi v2 and other libraries will work going forward, so that dApps won't always need to include wallet connectors; every installed wallet will just appear under Installed. If you add more wallets to your Recommended section in your example, or disable the OKX wallet or visit on mobile, those wallets will continue appear under Recommended.

from rainbowkit.

DanielSinclair avatar DanielSinclair commented on May 24, 2024 1

@SyedAhkam The missing string will be fixed in 2.0.0-beta.1 shortly.

from rainbowkit.

magiziz avatar magiziz commented on May 24, 2024 1

@SyedAhkam Yeah we will mention this in the upcoming docs once we merge beta into main branch. It'll be shown in the custom wallet list.

from rainbowkit.

magiziz avatar magiziz commented on May 24, 2024

@SyedAhkam This is an expected behaviour. OKX wallet supports EIP6963. If we detect an EIP6963 wallet we remove that same wallet you specified in the wallet list group.

The reason we do this is because it will be easier for the dApp to connect and manage wallets. There won't be any overridden bugs which usually happens if we don't support EIP6963 overrides.

Regarding the "Installed" missing that's expected. We haven't added localization support for that. It'll be fixed soon 🙏

from rainbowkit.

SyedAhkam avatar SyedAhkam commented on May 24, 2024

@SyedAhkam This is an expected behaviour. OKX wallet supports EIP6963. If we detect an EIP6963 wallet we remove that same wallet you specified in the wallet list group.

The reason we do this is because it will be easier for the dApp to connect and manage wallets. There won't be any overridden bugs which usually happens if we don't support EIP6963 overrides.

I understand the intent. However as it used to work fine in v1, but fails to in v2 -- we could call this a regression.

Now perhaps:

  1. You could add a way to override that EIP6963 wallet detection.
  2. or IMO The regression / breaking change should be mentioned in the new upcoming docs.

from rainbowkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.