Comments (5)
@SyedAhkam To clarify, the wallet you added is still available, it is just moved to an Installed
list at the top, because it is detected as installed by the new EIP-6963 connection standard. This is how Wagmi v2 and other libraries will work going forward, so that dApps won't always need to include wallet connectors; every installed wallet will just appear under Installed
. If you add more wallets to your Recommended
section in your example, or disable the OKX wallet or visit on mobile, those wallets will continue appear under Recommended
.
from rainbowkit.
@SyedAhkam The missing string will be fixed in 2.0.0-beta.1
shortly.
from rainbowkit.
@SyedAhkam Yeah we will mention this in the upcoming docs once we merge beta
into main
branch. It'll be shown in the custom wallet list.
from rainbowkit.
@SyedAhkam This is an expected behaviour. OKX wallet supports EIP6963. If we detect an EIP6963 wallet we remove that same wallet you specified in the wallet list group.
The reason we do this is because it will be easier for the dApp to connect and manage wallets. There won't be any overridden bugs which usually happens if we don't support EIP6963 overrides.
Regarding the "Installed" missing that's expected. We haven't added localization support for that. It'll be fixed soon 🙏
from rainbowkit.
@SyedAhkam This is an expected behaviour. OKX wallet supports EIP6963. If we detect an EIP6963 wallet we remove that same wallet you specified in the wallet list group.
The reason we do this is because it will be easier for the dApp to connect and manage wallets. There won't be any overridden bugs which usually happens if we don't support EIP6963 overrides.
I understand the intent. However as it used to work fine in v1, but fails to in v2 -- we could call this a regression.
Now perhaps:
- You could add a way to override that EIP6963 wallet detection.
- or IMO The regression / breaking change should be mentioned in the new upcoming docs.
from rainbowkit.
Related Issues (20)
- [bug] <title>when. using okxWallet, i get this error HOT 3
- Unable to connect to Argent Wallet HOT 2
- useChainId returns default chainId even if the current chain is not default. HOT 4
- [bug] fail to detect an installed wallet HOT 6
- [ReferenceError: localStorage is not defined] <Whenever `coinbaseWallet` is used in custom wallet list> HOT 5
- [bug] Once the wallet is connected, it will be disconnected immediately. HOT 3
- [bug] Metamask Issue in IOS Redirection Issue after connect or Sign & Switch Network Doesnt work on mobile HOT 3
- [bug] walletConnectWallet deosn't show in the modal HOT 5
- [bug] Rainbow wallet does not sign a message in Android and iOS. HOT 2
- [bug] <`useConfig` must be used within `WagmiProvider`.> HOT 1
- [bug] <Installed wallets are showing wallets that are not in the connectors array> HOT 2
- [bug] Connect wallet modal MM connect not doing anything HOT 3
- [Fraud, False Adveriting] <Rainbow's Fraud and False Advertising> HOT 5
- [bug] Cannot connect to WalletConnect in Chrome with enabled device toolbar HOT 2
- [bug] Can't connect Rainbow or CB mobile wallets using RainbowKit QR codes HOT 3
- [bug] Bybit wallet integration not working HOT 1
- [bug] Error when using `connectorsForWallets` to create connectors object in `cookieToInitialState` by wagmi HOT 2
- [bug] Touchpad zoom and pan do not work on modals HOT 3
- [bug] process.env breaks Vite-based projects in Dev HOT 1
- [bug] Coinbase wallet QR code scan not showing prompt consistently HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rainbowkit.