Comments (5)
This is something we did from the beginning as the easiest thing to get us going. Browsers usually don't complain and take whatever they have to work with, however I think this is a legitimate concern. I think we can put some work into injecting the markup at a more appropriate place.
Just curios, did you forgot the console
invocation during the test run or was it intended to be there?
from web-console.
I didn't invoke the console at all, as far as I know. All I have to do is include the web-console gem in my Gemfile, and then the elements & JS get injected into the error pages. I'm assuming this is automatic and on-purpose. :)
from web-console.
Hm, do we intend for web-console to run in test mode? Seems like it won't be useful there (and as it turned out, can cause problems). Generally, the test environment should be closer to production than development, so it probably shouldn't run in test mode?
from web-console.
@chancancode we never intended it to be used in test mode, but we don't enforce anything during runtime anymore.
from web-console.
This has been fixed by #162.
from web-console.
Related Issues (20)
- Deprecation warning for web console in Firefox
- Issue with web-console (4.0.3), rack (2.2.3) and webrick HOT 3
- Web console activated in test environment warning showing despite not being in test group HOT 1
- Readonly Access HOT 1
- ANSI escape codes not rendering correctly HOT 2
- Failing tests with Ruby 2.7 HOT 1
- Disable web console
- `WebConsole::EvaluatorTest#test_Evaluator_callers_are_cleaned_up_of_unneeded_backtraces` test failure HOT 1
- Breaking with Rails 6.1.rc1.
- CurrentAttributes gets reset for web-console requests HOT 10
- Wildcard host for ngrok HOT 2
- Still not working with Rails 6.1
- web-console gem error in ruby 2.7 and rails 6.1 HOT 2
- Missing template rails_web_console/console/run HOT 1
- Support for multiple web workers (websockets?) HOT 2
- Do not render web console for non-HTML requests HOT 5
- NameError: constant WebConsole::SourceLocation not defined HOT 13
- Faulty message: Web Console is activated in the test environment HOT 3
- Could web-console support meta keys? HOT 2
- Extend UI options for the console HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from web-console.