New `permanent_connection_checkout` does not seem to work as expected. about rails

[casperisfine]

First repro:

  def test_bare_connection
    assert_raises(ActiveRecord::ActiveRecordError) do
      post = Post.create!
      post.comments << Comment.create!
    end
  end

This assumption isn't correct. .create! will checkout and then check back in a connection.

[casperisfine]

Here's how it should be:

class BugTest < Minitest::Test
  def test_bare_connection
    refute_predicate Post.connection_pool, :active_connection?
    assert_raises(ActiveRecord::ActiveRecordError) do
      Post.connection
    end
  end
end

[ioquatix]

It doesn't seem to check the connection back in:

  def test_bare_connection
    # assert_raises(ActiveRecord::ActiveRecordError) do
      post = Post.create!
      post.comments << Comment.create!
    # end

    assert_equal 0, Post.connection_pool.stat[:busy] # fails here
  end

[ioquatix]

Thanks!