Coder Social home page Coder Social logo

unmatched visibility `pub` about avr-device HOT 4 CLOSED

rahix avatar rahix commented on June 30, 2024
unmatched visibility `pub`

from avr-device.

Comments (4)

Rahix avatar Rahix commented on June 30, 2024

Hmm, this might be related to #5? The only place where pub(crate) should appear is the line that is changed using sed in the Makefile ... I'll have a fix for that ready today in the evening, hopefully

from avr-device.

Rahix avatar Rahix commented on June 30, 2024

The line should actually be replaced by sed to look like

pub(crate) static mut DEVICE_PERIPHERALS: bool = false;

From the sed expression that is used (s/\(static mut DEVICE_PERIPHERALS\)/pub(crate) \0/), I would guess that your sed does not replace \0 correctly ... I am unsure why that would be the case, though

from avr-device.

Rahix avatar Rahix commented on June 30, 2024

Can you check if commit 7818dda fixed this issue as well? I changed the sed expression to use \1 instead, in hopes that this would be more portable ...

from avr-device.

peacememories avatar peacememories commented on June 30, 2024

It seems to work now 👍

from avr-device.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.