Comments (7)
Fixed. Just set pathPrefix
to true here and it will work with Project Pages sites not using a custom domain. Also updated the readme, so check that out for more info.
Let me know if you have any issues with this.
from spa-github-pages.
Just got confirmation from GitHub support that GitHub Pages now serves a custom 404 page for Project Pages sites without using a custom domain (GitHub docs are outdated and will be updated).
from spa-github-pages.
If it's a project pages site, then you have to use a custom domain in order for GitHub Pages to serve a custom 404 page. I talk a bit about how to set this up in the instructions with links to GitHub docs.
from spa-github-pages.
Thanks for your reply,
When I first used the code, I had all the url after the main domain, for example, https://username.github.io/repo/foo
turned into query-string >> https://username.github.io?p=repo/foo
, this didn't work well for Project Pages where the repo
name should stay, .. I might be missing on something here,
from spa-github-pages.
You're right, but it's a moot point because you must use a custom domain for GitHub Pages to serve a custom 404 page for a Project Pages site, see here, and the custom domain won't have /repo
at the beginning of the path.
I did a few tests this morning and it appears that GitHub Pages now serves a custom 404 page for Project Pages sites without using a custom domain (despite the docs still indicating the opposite). I'll reopen the issue and update the redirect scripts. Thanks for the heads up @websemantics.
Also, don't forget to include author cred along with my code in ghspa.js.
from spa-github-pages.
I never read the docs, ignorance -sometimes- is a bless hh
I already had a link to your repo in the original README.md and now clearly in ghspa.js,
The only added contribution I had was the switch between Project Pages and User/Org pages which your library now supports too,
I also had it packaged as Bower/Node package, and the setup/steps are slightly easier to follow (maybe),
- Include ghspa.js in
index.html
and404.html
- Set the title of
404.html
to404
- Done,
If you could probably make it as such, I really don't need that repo,
Thanks @RAFREX for the original contribution,
from spa-github-pages.
Oh, and a really fancy demo page which took way longer to build than writing code hhh
from spa-github-pages.
Related Issues (20)
- Redirect script link typo HOT 1
- about.html HOT 4
- Refreshing the page still throws a 404 error in the console. HOT 3
- Doesn't work with Next.js HOT 4
- How to inject environmental variables into 404.html? HOT 4
- Just saying thanks
- ? mark not being removed HOT 1
- No longer working for SEO purposes? HOT 2
- ['] being converted to [%27] and breaking React Router HOT 1
- Redirect stays on /?/ HOT 1
- React-router params HOT 2
- Bundle.js file isn't my build folder HOT 1
- Possible to have dynamic social media cards? HOT 1
- Shows a blank page on a route with a path of 2 hashes or more
- Update README for further clarification of instructions
- Mention alternative of `HashRouter` HOT 5
- Consider add GitHub Actions Support?
- Suggestion - Avoid 404's using meta tag HOT 2
- Assets 404 not found with Vite + React Router
- Getting infinite redirect? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spa-github-pages.