Comments (4)
I agree that it makes sense too, and your solution seems the best way of implementing this. Are you OK to make your suggested revisions directly?
from fscreen.
Good point. If you have time feel free to make a PR.
from fscreen.
Logically I have implemented this locally using:-
addEventListener: (element, type, handler, options) => element.addEventListener(vendor[key[type]], handler, options)
BUT I presume introducing a new initial ELEMENT parameter would represent a breaking change?
from fscreen.
That would be a breaking change, but I think it makes sense.. unless you have another idea.
Also the fscreen.onfullscreenchange
and fscreen.onfullscreenerror
would need to be updated too.. I'm thinking remove the getter and setters and have the api be fscreen.onfullscreenchange(element) = handler
which could be implemented as:
onfullscreenchange: element => element[`on${vendor[key.fullscreenchange]}`.toLowerCase()]
from fscreen.
Related Issues (19)
- Not working on Safari iOS HOT 5
- how to give custom message on full screen dialog like youtube HOT 1
- Provide indication of fullscreen support HOT 2
- In what language is this written on? HOT 2
- return Promise from requestFullscreen() HOT 2
- how to trigger full screen mode after a screen orientation change HOT 1
- Fullscreen not working in Chrome iOS, should it? HOT 3
- Black screen on Safari Desktop 12.4 and 13.1 HOT 2
- Chrome android exits fullscreen when keyboard is open. HOT 1
- support for options in requestFullscreen() HOT 2
- Safari support HOT 1
- Enabling fullscreen triggers a "visibilitychange" event on safari HOT 1
- `requestFullscreen()` doesn't work after YouTube video played full screen
- fullscreenEnabled is false for Safari and Chrome on iOS HOT 1
- Fscreen block dialog to open HOT 2
- prefixing: what about Samsung SmartTV browsers? HOT 3
- wondering why fullscreen events aren't thrown when user uses menu commands to enter full screen HOT 2
- Unable to zoom in mobile browsers when in full screen. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fscreen.