Liquidsoap hanging on shutdown about centos-rpm-liquidsoap

[hairmare]

The RPMs are built against ocaml-duppy 0.8.0.

I'm also looking forward to rebuilding against a new release on ocaml-gstreamer, although it might take some time to do so after the it is released depending on if we need a newer ocaml version that what is available in CentOS.

Apart from not using gstreamer (I don't use it and I haven't seen you issues) I don't have any ideas on how to fix and/or workaround this.

Let me know if you figure out if any other dependency update can help and I'll bump it and do a rebuild.

[AxisNL]

@hairmare , thanks for your reply! Then I know ocaml-duppy is not the issue. I got a reply from @crocket in the thread savonet/ocaml-gstreamer#12, telling me I should just use the pull request as a patch: https://patch-diff.githubusercontent.com/raw/savonet/ocaml-gstreamer/pull/11.patch.

Would this work?

[hairmare]

Let me check if it applies to the latest ocaml-gstrreamer tag and I can tell you. Preferably some input from the savonet team would be nice though.

[hairmare]

This is weird, gstreamer can't be your issue, the RPM is built without it. The following section from the configure output show that gst isn't enabled:

* Input / output 
- Icecast/Shoutcast : yes 
- AO : no (requires ao) 
- OSS : yes 
- ALSA : yes 
- Portaudio : no (requires portaudio) 
- Pulseaudio : no (requires pulseaudio) 
- JACK : yes 
- GStreamer : no (requires gstreamer)

I guess we can rule out gstreamer being the issue 😛

Can you check if the issue still occurs with 1.3.7? There is an 1.3.7 package in the repo so updating should be easy.

[hairmare]

I just realized, the old 1.3.6 RPMs have probably never been rebuilt against ocaml-duppy 0.8.0... If you issue is really fixed with the duppy change we can't rule that out unless you can reproduce with the 1.3.7 packages. Building 1.3.6 RPMs with a bumped duppy would in theory be possible but it's well outside of the scope of what we at @radiorabe can support.

[AxisNL]

Yeah, we're trying 1.3.7 as we speak. I think we've had the issue again, but have to check to confirm..

to be sure:
$ rpm -qa | grep liq
liquidsoap-1.3.7-82.1.x86_64
$ md5sum /usr/bin/liquidsoap
4ffe52cc646da0bb208d168835b13927 /usr/bin/liquidsoap
$ liquidsoap --version
Liquidsoap 1.3.7
Copyright (c) 2003-2019 Savonet team
Liquidsoap is open-source software, released under GNU General Public License.
See http://liquidsoap.info for more information.

[TheRealMattLear]

Our users are also complaining of shutdown issues from this RPM build. We've moved to manually compiled instances via OPAM with OCAML 4.07.1 and this has resolved the problems. We'd lve to switch back over to the RPM builds once this is resolved!

[hairmare]

I just pushed liquidsoap 1.4.3 packages for CentOS 8 to the repos 🚀 Can you check if this still reproduces using those packages on CentOS 8?

[AxisNL]

Our control panel provider upgraded to 1.4 (compiled via opam), and since then we haven't seen these issues anymore! So thanks everyone!