Helm-minibuffer-history interferes with backward search: simple solution about ctrlf

[andersjohansson]

In my testing the new change seems to solve the problem for helm-minibuffer-history.

[jsigman]

It stopped being a problem and I can't recreate it

[hartzell]

I ran into the same issue, but with counsel-minibuffer-history. The solution above makes things work for me (using straight):

(use-package ctrlf
  :init
  (ctrlf-mode +1)
  :config
  (add-to-list 'ctrlf-minibuffer-bindings '("C-r" . nil)))

[raxod502]

Should be fixed, please test.

[hartzell]

Works for me. Thanks!

[andersjohansson]

This works for me too. Big thanks! Although I am a bit confused as to why this works, since I thought the changes in bindings for ctrlf--keymap shouldn’t override the minibuffer bindings inherited from minibuffer-local-map (where helm-minibuffer-history is bound to C-rfor me) when I am in a ctrlf-session. There is something that I don’t quite understand about emacs bindings it seems.

[raxod502]

I thought the changes in bindings for ctrlf--keymap shouldn’t override the minibuffer bindings inherited from minibuffer-local-map

Perhaps it has to do with the fact that ctrlf-mode is a minor mode, and minor mode keymaps typically override everything else. Otherwise, it wouldn't be possible to enable a minor mode in the minibuffer and have it override minibuffer bindings.

[andersjohansson]

Perhaps it has to do with the fact that ctrlf-mode is a minor mode, and minor mode keymaps typically override everything else. Otherwise, it wouldn't be possible to enable a minor mode in the minibuffer and have it override minibuffer bindings.

I see!

[raxod502]

I've come up with a more robust keymapping scheme. It's a bit of a hack but should address the conflicting needs of these various bug reports. My new solution should solve #51, #52, #67, and #80 simultaneously while also working with remap bindings. I have tested it a bit and it seems to work, but I don't actually use most of the modes that have been mentioned in these issue reports, so I could use some help to confirm if the bug is resolved for all of them.

[jsigman]

I get the same interference with helm-minibuffer-history using the latest code, and (add-to-list 'ctrlf-minibuffer-bindings '("C-r" . nil) disables using C-r to move backwards, as well. Is this known?

[raxod502]

I don't think so. Can you open a separate issue for that? I just tested by setting

(define-key minibuffer-local-map (kbd "C-r") (lambda () (interactive) (message "Hello world!")))

to emulate what Helm does in binding a key in minibuffer-local-map, and typing C-r C-r still has the expected effect.

Notably, running

(add-to-list 'ctrlf-minibuffer-bindings '("C-r" . nil)

as you say you've done should not disable C-r, as it should result in the [remap isearch-backward] binding taking precedence instead. Something peculiar must be going on.