Comments (6)
I think you mean C-x C-f
followed by M-r
, because in vanilla Emacs C-x C-f
followed by C-r
just does an Isearch on the current contents of the minibuffer, without any interaction with history. Let me know if I guessed wrong here.
Anyway, I pushed a commit that should fix all the compatibility issues. Let me know if it works for you.
from ctrlf.
(I'm assuming you are using Selectrum, because otherwise I can't think of any reason M-r
would not work. See radian-software/selectrum@551b119.)
from ctrlf.
Multiple separate but related problems here with both ctrlf and selectrum, I'm not exactly sure how to keep the conversation organized between this and radian-software/selectrum#4, but I'll try. :)
in vanilla Emacs C-x C-f followed by C-r just does an Isearch on the current contents of the minibuffer, without any interaction with history.
No, it definitely interacts with history! When used in find-file
, C-r
does a search through file-name-history
, not the default minibuffer-history
. I'll comment on that further in the other ticket.
The breakage I'm referring to here occurs when ctrlf
is the only package installed in an Emacs sandbox (no configuration, naturally). Steps to reproduce:
- enable
ctrlf-mode
C-x C-f
C-r
errors out:ctrlf--start: Command attempted to use minibuffer while in minibuffer
The expected result is incremental search through file-name-history
. It's okay to fall back on isearch-backward
here rather than ctrlf-backward-*
.
from ctrlf.
Okay. Thanks for the explanation. This is bizarre to me because I cannot find the code that implements this behavior anywhere in Isearch. It would be helpful if someone could point to the implementation. That would help to determine why using Isearch within Selectrum breaks ("text is read-only" error).
from ctrlf.
I guess that's a separate issue, though, from CTRLF overriding the bindings which also breaks usage without Selectrum. Open a new issue against Selectrum if it bothers you; the bug you reported here should be fixed.
from ctrlf.
This thread is being closed automatically by Tidier because it is labeled with "waiting on response" and has not seen any activity for 90 days. But don't worry—if you have any information that might advance the discussion, leave a comment and I will be happy to reopen the thread :)
from ctrlf.
Related Issues (20)
- Lacks isearch-query-replace HOT 5
- Can it support wgrep in occur mode? HOT 1
- Question: How to add Chinese pinyin support? HOT 1
- Doesn't honor search-invisible HOT 1
- C-g behaves like RET HOT 4
- first character is not deleted HOT 9
- moving the mark back into the main buffer leaves things in a goofy state HOT 4
- Renaming default branch from 'master' to 'main' HOT 1
- C-r wrong HOT 2
- Don't jump to invisible text HOT 1
- Does not open up org mode folded headings HOT 2
- How do I customise `ctrlf-minibuffer-bindings` in my config? HOT 2
- Expose match count/index for modeline segments? HOT 1
- C-s and C-r doesn't always search the next or previous occurrence. HOT 2
- Other messages in minibuffer HOT 5
- Does not work in specific special buffer HOT 1
- Go to next match after "ending" search HOT 5
- No isearch-esque unprettifying while searching HOT 2
- Mention isearch-mb in the readme HOT 1
- isearch-repeat-forward? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ctrlf.