Test suite: 1 failure about by_star

[radar]

I am also seeing this test failing on my machine.

  1) Time fortnight middle of year beginning_of_fortnight should eq 2014-06-04 00:00:00 +1000
     Failure/Error: its(:beginning_of_fortnight){ should eq Time.parse('2014-06-04') }

       expected: 2014-06-04 00:00:00 +1000
            got: 2014-06-03 23:00:00 +1000

       (compared using ==)

       Diff:
       @@ -1,2 +1,2 @@
       -2014-06-04 00:00:00 +1000
       [phone]:00:00 +1000
     # ./spec/unit/kernel_time_spec.rb:32:in `block (4 levels) in <top (required)>'

  2) Time fortnight middle of year end_of_fortnight should eq 2014-06-17 23:59:59 +1000
     Failure/Error: its(:end_of_fortnight){ should eq Time.parse('2014-06-17').end_of_day }

       expected: 2014-06-17 23:59:59 +1000
            got: 2014-06-16 23:59:59 +1000

       (compared using ==)

       Diff:
       @@ -1,2 +1,2 @@
       -2014-06-17 23:59:59 +1000
       [phone]:59:59 +1000
     # ./spec/unit/kernel_time_spec.rb:33:in `block (4 levels) in <top (required)>'

Regarding the mongoid specs, all you need is a MongoDB server running in the background. I've installed mine on my machine using brew install mongodb and I run it using mongod in another window, closing that window when I don't need it.

@johnnyshields Since you're now the resident expert at this, how can we debug what's going on here?

[johnnyshields]

Firstly, this unit test is in the "unit" folder which means it is not dependent on either Mongoid or ActiveRecord.

This looks like it may be DST related. I've pushed a fix here: d06a2b4

[radar]

Excellent! That fixes it for me.