Coder Social home page Coder Social logo

FATAL error in unpacker about r3broot HOT 4 OPEN

ManuelXarepe avatar ManuelXarepe commented on July 28, 2024 1
FATAL error in unpacker

from r3broot.

Comments (4)

jose-luis-rs avatar jose-luis-rs commented on July 28, 2024

In R3BRoot/r3bsource/base/R3BUcesbSource.cxx

Look for the lines:

        R3BLOG(fatal,
               "ext_data_clnt::setup() mapping failure may "
               "cause unexpected analysis results due to missing "
               "data members. Unpacker needs fixing.");

and change R3BLOG(fatal, ... by R3BLOG(error,...

from r3broot.

ManuelXarepe avatar ManuelXarepe commented on July 28, 2024

Thank you for the fast response. To be clear what you are suggesting is to open a PR with this change, which is essentially reverting #712?

from r3broot.

ManuelXarepe avatar ManuelXarepe commented on July 28, 2024

I apologize, as I had not read through the entire discussion on #712 before, and just went through it now. If I understood correctly from #712 (comment), the proposal is to do a local modification that changes the R3BLOG(fatal, back to R3BLOG(error,.

I am afraid, however, this is not a sustainable solution long term. I believe that other people will also run into this issue and maintaining local changes that are not merged long-term can become messy and difficult to maintain. It will also generate many requests for support as students encounter this issue and don't know how to fix it.

I am a little out of my depth here, but if we were able to find a solution for the underlying issue, which is that different experiments required a different set of ext_* files, it would be ideal.

My naive solution would be to divide this ext_file in 4 different ext files, treating each MWPC as a different detector, all being called by the same reader class. However, I don't really know how this would be implemented. Is this even a feasible solution?

I will change the code as you suggested in my working environment for now, to unblock me, but will keep this issue open so that we can discuss a better solution.

from r3broot.

klenze avatar klenze commented on July 28, 2024

This issue was anticipated by me and discussed here.

Personally, I do not particularly like the nested arrays (implemented by ntuples which have indices as part of their name) and would prefer to move to a flat structures like CALIFA does. This involves a bijection between ${\mathbb{N}_0}^m$ and $\mathbb{N}_0$ (e.g. an absolute channel index), but such have been known to exist since Cantor.

The main problem is that is such changes have to be synchronized between the unpackers and R3BRoot, which is non-trivial.

from r3broot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.