Comments (4)
In R3BRoot/r3bsource/base/R3BUcesbSource.cxx
Look for the lines:
R3BLOG(fatal,
"ext_data_clnt::setup() mapping failure may "
"cause unexpected analysis results due to missing "
"data members. Unpacker needs fixing.");
and change R3BLOG(fatal, ... by R3BLOG(error,...
from r3broot.
Thank you for the fast response. To be clear what you are suggesting is to open a PR with this change, which is essentially reverting #712?
from r3broot.
I apologize, as I had not read through the entire discussion on #712 before, and just went through it now. If I understood correctly from #712 (comment), the proposal is to do a local modification that changes the R3BLOG(fatal
, back to R3BLOG(error,
.
I am afraid, however, this is not a sustainable solution long term. I believe that other people will also run into this issue and maintaining local changes that are not merged long-term can become messy and difficult to maintain. It will also generate many requests for support as students encounter this issue and don't know how to fix it.
I am a little out of my depth here, but if we were able to find a solution for the underlying issue, which is that different experiments required a different set of ext_* files, it would be ideal.
My naive solution would be to divide this ext_file in 4 different ext files, treating each MWPC as a different detector, all being called by the same reader class. However, I don't really know how this would be implemented. Is this even a feasible solution?
I will change the code as you suggested in my working environment for now, to unblock me, but will keep this issue open so that we can discuss a better solution.
from r3broot.
This issue was anticipated by me and discussed here.
Personally, I do not particularly like the nested arrays (implemented by ntuples which have indices as part of their name) and would prefer to move to a flat structures like CALIFA does. This involves a bijection between
The main problem is that is such changes have to be synchronized between the unpackers and R3BRoot, which is non-trivial.
from r3broot.
Related Issues (20)
- UCESB cannot populate items in client_struct_info with client.setup HOT 2
- Proposal for reimplementing the TofD calibration
- Clang-tidy setting HOT 24
- Design Guidelines for R3BRoot HOT 1
- Unknown Type name 'FairMCTracks' HOT 1
- Error in <TExMap::Add>: key is not unique HOT 1
- Clang-formatting - what should be included, what should be removed, future additions HOT 10
- File to generate Hit Parameters using Los not in GitHub repository HOT 5
- Proposal to remove ext files from dev branch HOT 19
- Bug CALIFA QPID Simulation HOT 4
- Forbid pull requests from the dev branch? HOT 6
- Spell fixes by `codespell` HOT 3
- Auto-generated ext_h101 structs HOT 3
- Policy discussion: on pull requests, merging and reviews HOT 12
- Unknown CMake command "fair_pad" HOT 2
- Added new repository for lmds and analysis CI tests HOT 2
- About clang-tidy and code standard HOT 11
- Problems with the compilation of new reader data structures: TTTX HOT 4
- [Proposal] Metadata file for experiments? HOT 24
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from r3broot.