Comments (6)
I recommend adding:
SpaceAfterLogicalNot: false
SpaceBeforeAssignmentOperators: true
SpaceBeforeCpp11BracedList: true
SpaceBeforeCtorInitializerColon: true
SpaceBeforeInheritanceColon: true
SpaceBeforeParens: ControlStatements
SpaceBeforeRangeBasedForLoopColon: true
NamespaceIndentation: All
AlignTrailingComments: false
AllowAllConstructorInitializersOnNextLine: false
AllowAllParametersOfDeclarationOnNextLine: true
AllowShortFunctionsOnASingleLine: Empty
AlwaysBreakAfterDefinitionReturnType: None
AlwaysBreakAfterReturnType: None
AlwaysBreakTemplateDeclarations: No
BinPackArguments: false
BinPackParameters: false
ExperimentalAutoDetectBinPacking: false
IndentCaseLabels: false
ObjCBinPackProtocolList: Auto
SpaceAfterCStyleCast: false
SpaceInEmptyParentheses: false
Standard: Cpp11
This fixes basically all the wacky issues with clang-format, and specifies some more strict formatting rules (I based this on what is already used in the code).
from northstarlauncher.
These lines from @KittenPopo's config should be enough to fix those pathological "to the moon" cases:
BinPackArguments: false
BinPackParameters: false
ExperimentalAutoDetectBinPacking: false
clang-format 14 also supports AlignAfterOpenBracket: BlockIndent
, which turns this:
NSMem::BytePatch(
ba + 0x18ED8D,
{
0xC3 // jmp => ret
});
into this, which is maybe a bit cleaner:
NSMem::BytePatch(
ba + 0x18ED8D,
{
0xC3 // jmp => ret
}
);
from northstarlauncher.
Sweet, we should upgrade to 14!
into this, which is maybe a bit cleaner:
NSMem::BytePatch( ba + 0x18ED8D, { 0xC3 // jmp => ret } );
Much cleaner! This is what I was trying to get clang-format to do lol
from northstarlauncher.
^--- @abarichello might wanna check that out ;)
from northstarlauncher.
clang-format 14 only released like 3 weeks ago, so the action we use doesn't support it yet :c
I opened an issue with them for now to see if/when support will be added.
from northstarlauncher.
Before messing with clang-format we should probably make sure that it accepts current code. Hence #143 to format code to current version of clang-format.
from northstarlauncher.
Related Issues (20)
- Add squirrel profiler/debugger HOT 1
- Modded persistence support
- Rework `-vanilla` launch option to be a vanilla compatibility mode HOT 2
- Auto-mod-dl: Check TS zip name to match format HOT 1
- Re-implement Squirrel's `Assert` function
- Incorrect plugin name used in logs HOT 4
- Bump compiler warnings and fail CI on compiler warnings
- Always log request id with master server
- Parse error for some "verification timed out" response HOT 7
- [Windows 7] Crash on startup: "The procedure entry point CreateFile2 could not be located in the dynamic link library KERNEL32.dll" HOT 2
- Add step to CI to also compile under Wine
- Remove undefined behaviour in Vector3 and QAngle
- Listen server log spam HOT 2
- Private game settings don't apply (vanilla) HOT 1
- Submodule rapidjson HOT 1
- Add Action to format cmake files
- -nojoy in dedi
- Check for duplicate files among enabled mods HOT 15
- Disable MAD mods on leaving server HOT 8
- Look into submoduling silver-bun
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from northstarlauncher.