Don't set hq as the default ALPN protocol in quinn-proto about quinn

[stammw]

Hello,

I'd like to try to solve this one !

If understand well, this ALPN parameter could be set in endpoint building code like so:

builder
    .logger(log.clone())
    .config(quinn::Config {
        max_remote_bi_streams: 64,
        alpn_protocols: vec!["hq-11"],
        ..Default::default()
}).listen();

or

let mut builder = quinn::Endpoint::new();
builder.set_alpn_protocols(vec!["hq-11"]);

These two options would let a possibility for the the user not to give any ALPN value. Is that desirable, or is it better to make this parameter mandatory?

[djc]

Hi @stammw, that would be great! I think we would want a method on EndpointBuilder that operates similar to set_certificate() and enable_keylog(): something that mutates the ClientConfig contained in the existing Config. @Ralith any thoughts?

[stammw]

Then TLS's ALPN parameter would be left empty when this method has never been called ?

[djc]

Yeah, I think that would be okay for some use cases, but I'll await the other reviewer.

[Ralith]

Yes, to the best of my knowledge ALPN is an optional part of the handshake.

[djc]

This has been fixed in #47. Thanks, @stammw!

[stammw]

Thank you both for all the time spent reviewing and helping !