Coder Social home page Coder Social logo

Comments (6)

maximumpower55 avatar maximumpower55 commented on August 21, 2024

LibJF uses fabric loader's internals, ModContainerImpl to be more specific, so its not really fixable

from quilt-loader.

Julienraptor01 avatar Julienraptor01 commented on August 21, 2024

LibJF uses fabric loader's internals, ModContainerImpl to be more specific, so its not really fixable

is it fixable on the dev side with really little changes ? (I've already talked with him but he responded me that he shouldn't have to do smth as quilt said it would support fabric mods. But if it only require small chnages i can try to ask him to still do it or to do a fork myself.)

from quilt-loader.

AlexIIL avatar AlexIIL commented on August 21, 2024

To be specific, LibJF creates entrypoint objects directly, which isn't exposed as functionality directly through either fabric-loader api or quilt-loader api. The closest approximation would be to use FabricLoader.getEntrypoints() - however this might not be sufficient, depending on why LibJF chose to create entrypoint objects directly.

from quilt-loader.

AlexIIL avatar AlexIIL commented on August 21, 2024

Upon closer inspection, it looks like LibJF (ab)uses language adapters to expose an even earlier entrypoint for mods to use. This means they are trying to get entrypoints too early for normal entrypoints methods - since they require language adapters to be setup.

I can't see an easy fix for this, since it depends on why LibJF exposes entrypoints that early.

from quilt-loader.

Julienraptor01 avatar Julienraptor01 commented on August 21, 2024

From JFronny

The hacky parts in libjf are needed for manual ASM (for example in powerless, mAME or data-manipulation, which respackopts builds on) and mod injection (for example in modsmod or mixwork) with access to properly loaded configs, both of which are needed elsewhere

from quilt-loader.

AlexIIL avatar AlexIIL commented on August 21, 2024

Okay, in which case libjf is most likely entirely incompatible with quilt, since it interacts directly with lot more of fabric loader internals than just entrypoints - it's probably not going to be possible for us to support that.

from quilt-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.