Package contents cannot have a node named 'file' about quilt

[evamaxfield]

Yep, I realized the issue a little while ago. Definitely a mistake on my part not following build manifest spec.

[evamaxfield]

Resolved:

Individual files cannot be named file.{extenstion}.
In my case, file.tif was not a valid path for contents of package.

[dimaryaz]

Good catch! Actually, that is a real bug - you should be free to use the name file. We'll fix it.

[evamaxfield]

@dimaryaz Renamed issue for better tracking. Good luck!

[eode]

Actually, this isn't a bug. Perhaps the design needs changing, but it's by design.

It's not a file named 'file.xyz' that is the problem, it's having a node named 'file'. Also, the error occurs during build, not push. That error is really a beast, though, and it's very obscure to users what is actually happening. At the very least, we should change the error message, and perhaps we should change the quilt build file format.

So, for example:

# this package fails with the reported (obscure and unhelpful) error
contents:
  file:
    file:  baz.tif

# this package succeeds
contents:
  file_:        # note the underscore
    file: file.tif

This is because file is a quilt keyword used to specify that the containing node references a file. So, you can reference a file named file, or named file.file, but you can't have a node named file.

I'm going to have a conversation with some others about this, and do some checks in the code to ensure that the issue doesn't cause problems elsewhere. As long as that comes up clean, we could potentially be able to determine that it's being used as a keyword or not by the data it contains.

[eode]

True, but we've decided to allow this behaviour, so in the future you should be able to have packages which use keywords as node names, at least to some extent (including the case you have here).

[akarve]

Partially tackled in #414 and will improve with planned syntax checking for build.yml files