Coder Social home page Coder Social logo

Comments (2)

meling avatar meling commented on May 29, 2024

A small snag: Submission does not have CourseID, which isn't required for the logic of updateSubmission(), but is required by access control.

from quickfeed.

meling avatar meling commented on May 29, 2024

The current messages could also be converted to just one message as below:

message UpdateSubmissionRequest {
    uint64 submissionID      = 1;
    uint64 courseID          = 2;
    uint32 score             = 3;
    bool released            = 4;
    Submission.Status status = 5;
}

message UpdateSubmissionsRequest {
    uint64 courseID     = 1;
    uint64 assignmentID = 2;
    uint32 scoreLimit   = 3;
    bool release        = 4;
    bool approve        = 5;
}

Like this:

// UpdateSubmissionRequest is used to update manually reviewed submissions.
message UpdateSubmissionRequest {
    uint64 CourseID          = 1;
    uint64 AssignmentID      = 2;  // if non-zero, update all submissions
    uint64 SubmissionID      = 3;  // if non-zero, update single specific submission
    uint32 Score             = 4;  // only used for single submission
    bool Release             = 5;  // indicate whether or not to release submission(s) to students
    Submission.Status Status = 6;
}

It is unclear if we need to use the scoreLimit field when submitting submissions for all students. To me, it makes more sense to let the server decide whether or not a submission's (recorded) score is higher than the assignment's score limit.

That said, these custom rules for the fields may be too convoluted and we should stick with something simpler. Or find a better option.

from quickfeed.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.