Error Page Sync about django-nextjs

[danialkeimasi]

Hi. Currently, we don't have the necessary settings to support this. However, I believe it can be achieved with the following code in each view:

# views.py

from django.http import Http404
from django_nextjs.render import render_nextjs_page


async def jobs(request):
    response = await render_nextjs_page(request)

    if response.status_code == 404:
        raise Http404

    return response

I propose adding a setting for this purpose. Perhaps we can call it RAISE_ON_404 or something similar. Do you think this would be beneficial?

[danialkeimasi]

I should say that we can't raise Http404 in render_* function since it is not expected by normal Django's render function. Instead we should create some kind of view that can be configurable.

[lawrenceuchenye]

@danialkeimasi that seem better tho the issue is how to go about it.

[danialkeimasi]

For now, you can write a re-usable view (with adding *args, **kwargs to it) in your own code and re-use it for all pages like this:

# reusable_nextjs_page.py

from django.http import Http404
from django_nextjs.render import render_nextjs_page


async def nextjs_page(request, *args, **kwargs):
    response = await render_nextjs_page(request)

    if response.status_code == 404:
        raise Http404

    return response

and use it like this:

# urls.py
from django.urls import path
from reusable_nextjs_page import nextjs_page


urlpatterns = [
    path("/companies", nextjs_page, name="companies"),
    path("/companies/<str:slug>", nextjs_page, name="company"),
]

[lawrenceuchenye]

Hi being bug huntering for a while so being off i tried the import for render_nextjs_page but it's not working i can't import the package named "render_nextjs_page"

[danialkeimasi]

This isn't an actual import statement from a external package. It's just pseudo-code to demonstrate how you can create a reusable view in your own codebase.

[danialkeimasi]

I have been thinking about it, since creating a reusable view is simple, I suggest we skip it to keep the API less complex.

[lawrenceuchenye]

Ok wrote the code without the async but it still didn't trigger the custom nextjs 404 page

code snippet
def uni_nextjs_page_view(request, *args, **kwargs): res = render_nextjs_page_sync(request) print("STATUS CODE:{}".format(res.status_code)) if res.status_code == 404: raise Http404 return res

[lawrenceuchenye]

def uni_nextjs_page_view(request, *args, **kwargs):
res = render_nextjs_page_sync(request)
print("STATUS CODE:{}".format(res.status_code))
if res.status_code == 404:
raise Http404
return res

[lawrenceuchenye]

I have being able to make the error pages show in production but now the css is not showing

[lawrenceuchenye]

Also thank you @danialkeimasi very much for the help