Coder Social home page Coder Social logo

Comments (25)

SouthRibbleTech avatar SouthRibbleTech commented on July 30, 2024 2

@hawkeye64 I can also confirm that this is working again. Thank you.

from quasar-ui-qmarkdown.

mesqueeb avatar mesqueeb commented on July 30, 2024 1

Fixed it by doing: no-container="true"

not sure what the bug is though.

from quasar-ui-qmarkdown.

hawkeye64 avatar hawkeye64 commented on July 30, 2024

yeah, I have no idea. Will investigate.

from quasar-ui-qmarkdown.

hawkeye64 avatar hawkeye64 commented on July 30, 2024

I'd say, please use yarn and see if the issue persists. Don't forget to remove node_modules and package.lock (or, whatever it's called) file.

from quasar-ui-qmarkdown.

hawkeye64 avatar hawkeye64 commented on July 30, 2024

@mesqueeb By chance do you have two separate instances of QMarkdown being loaded? One being used by one component and another used by a different component?

from quasar-ui-qmarkdown.

hawkeye64 avatar hawkeye64 commented on July 30, 2024

Have a feeling markdownItContainer is doing something globally that conflicts.

from quasar-ui-qmarkdown.

apasov avatar apasov commented on July 30, 2024

I also started getting this error after upgrading to v1.0.12
In my case there are two errors. In addition to Cannot read property 'block' of undefined I get Cannot read property 'render' of undefined:

image
image

Both are fixable by :no-container="true"

from quasar-ui-qmarkdown.

SouthRibbleTech avatar SouthRibbleTech commented on July 30, 2024

I can also confirm that :no-container="true" works. Thanks @apasov I have spent 2 hours thinking I was going senile.

from quasar-ui-qmarkdown.

SouthRibbleTech avatar SouthRibbleTech commented on July 30, 2024

I am noticing that some markdown is not working i.e. ::: this is not displayed as a block :::

from quasar-ui-qmarkdown.

hawkeye64 avatar hawkeye64 commented on July 30, 2024

@apasov @SouthRibbleTech Can you upgrade to v1.0.13 and tell me if you are still getting the container issue?

from quasar-ui-qmarkdown.

Lecraminos avatar Lecraminos commented on July 30, 2024

I can confirm the above issue and "fix" in a similar setting (Chrome 79 on Manjaro) and unfortunately the error persists even after upgrading to 1.0.13... Used to work in 1.0.11, but interestingly even a downgrade (including removal of lock-file and node_modules) does not solve the issue anymore... Might it be introduced by a dependency upgrade?

from quasar-ui-qmarkdown.

apasov avatar apasov commented on July 30, 2024

@SouthRibbleTech lol)
@hawkeye64 Yes, I had already upgraded to v1.0.13 when I was writing the previous comment. The issue appeared after upgrading from v1.0.11 to v1.0.12

from quasar-ui-qmarkdown.

hawkeye64 avatar hawkeye64 commented on July 30, 2024

So, fixed with v1.0.13?

from quasar-ui-qmarkdown.

apasov avatar apasov commented on July 30, 2024

No, not fixed.

from quasar-ui-qmarkdown.

hawkeye64 avatar hawkeye64 commented on July 30, 2024

@apasov @Lecraminos @mesqueeb I would appreciate it if you guys would install the latest and verify the latest (v1.0.15) put this issue to bed. Thanks. ❤️

from quasar-ui-qmarkdown.

apasov avatar apasov commented on July 30, 2024

I confirm. Works without :no-container="true"
Thanks!

from quasar-ui-qmarkdown.

hawkeye64 avatar hawkeye64 commented on July 30, 2024

Perfect!

from quasar-ui-qmarkdown.

mesqueeb avatar mesqueeb commented on July 30, 2024

@hawkeye64 sadly it didn't work for me. : (
I'm still getting the error.

from quasar-ui-qmarkdown.

hawkeye64 avatar hawkeye64 commented on July 30, 2024

Yes, it's back. The fix breaks SSR, so had to revert it. To implement the fix yourselves, don't install the app-extension (unless you need *.md or *.vmd imports). Instead, install the @quasar/quasar-ui-qmarkdown component by itself. Then you have to write a boot file, and this is different than normal.

import Vue from 'vue'
import VuePlugin from '@quasar/quasar-ui-qmarkdown/src/index.js'
// normally the above line would be like this: import VuePlugin from '@quasar/quasar-ui-qmarkdown'

Vue.use(VuePlugin)

The problem lies within how the markdown-it plugins are created and imported. I have tried two different transpilers with rollup with different outcomes. I may have to implement babel, but really didn't want to. Or, make copies of all the plugins (maintenance nightmare) and write them properly for the transpiler.

from quasar-ui-qmarkdown.

mesqueeb avatar mesqueeb commented on July 30, 2024

@hawkeye64 perhaps a great time to consider marked!
https://bundlephobia.com/[email protected]

It's 4 times smaller and is more popular on Github. 😉

from quasar-ui-qmarkdown.

hawkeye64 avatar hawkeye64 commented on July 30, 2024

@mesqueeb Thanks, I'll take a look at it

from quasar-ui-qmarkdown.

mesqueeb avatar mesqueeb commented on July 30, 2024

@hawkeye64 it couldn't find the library when I did

import QMarkdown from 'quasar-ui-qmarkdown/src/index.js'

But it did when I did this:

import QMarkdown from '@quasar/quasar-ui-qmarkdown/src/index.js'

just a heads up for the others 😉

from quasar-ui-qmarkdown.

hawkeye64 avatar hawkeye64 commented on July 30, 2024

@mesqueeb Thanks. I updated my example. Note, I found doing it that way breaks SSR.

Currently, investigating other markdown providers, including writing my own with AST parser to get better performance. This may take some time to come up with the best solution, but want something that is very long-term and not a band-aid (plaster).

from quasar-ui-qmarkdown.

hawkeye64 avatar hawkeye64 commented on July 30, 2024

@apasov @Lecraminos @mesqueeb Such a tough bug. I have figured it out and have a fix. Look forward to a future release after I finish the rest of my testing.

from quasar-ui-qmarkdown.

hawkeye64 avatar hawkeye64 commented on July 30, 2024

Fixed (finally) in v1.0.20

from quasar-ui-qmarkdown.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.