Coder Social home page Coder Social logo

Comments (7)

quarkus-bot avatar quarkus-bot commented on August 31, 2024

/cc @glefloch, @quarkusio/devtools

from quarkus.

aloubyansky avatar aloubyansky commented on August 31, 2024

It looks like it can't resolve the deployment project for validation purposes. I am not sure we can do much about it but build extensions completely or disable validateExtension task

from quarkus.

mikethecalamity avatar mikethecalamity commented on August 31, 2024

@aloubyansky Could I add something to the json-logging/build.gradle like:

afterEvaluate {
    validateExtension.dependsOn project(':json-logging-deployment').???
}

I just don't know what task from json-logging-deployment that it depends on.

from quarkus.

aloubyansky avatar aloubyansky commented on August 31, 2024

Afaiu, the deployment subproject needs to be a part of the project build, since this task is validating its dependencies.
You need to be careful not to introduce a cyclic dependency, since deployment depends on runtime.
Practically though, I am not sure why you would not want to build them as a "unit".

from quarkus.

mikethecalamity avatar mikethecalamity commented on August 31, 2024

I do want to build them as a "unit", but the way builds work for our system requires everything to be able to be built "solo". And I use quotes there because json-logging-deployment can be built as part of json-logging, if there's a way I can add it to the build.gradle. Such that building the json-logging project builds them both. I'm just not sure what I could add in either of their build.gradles to accomplish this.

from quarkus.

aloubyansky avatar aloubyansky commented on August 31, 2024

I think for the validation to work, the deployment subproject has to be included in the build. TBH, I am not sure how you can do that from the runtime subproject, except building the whole "extension" (https://github.com/mikethecalamity/quarkus-test/tree/master/extensions
/subprojects)
Alternatively, validateExtension task could be disabled. Perhaps, we should just move validateExtension to the deployment module but it would still be validating the runtime one.

from quarkus.

mikethecalamity avatar mikethecalamity commented on August 31, 2024

I'll disable validateExtension for now. But it does sound reasonable for it to be on the deployment module.

from quarkus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.