Comments (14)
Follows up #38
from quarkus.
@mkouba isn't this done?
from quarkus.
I'm not sure. @manovotn could you pls verify the relevant functionalities?
from quarkus.
@cescoffier @mkouba
Well, Arc deliberately doesn't implement specialization so there's that.
Other than that, in type-level inheritance, we seem to be missing qualifier and stereotype inheritance while scope and interceptor bindings work.
Member-level inheritance seems to work fully.
I've written these tests to try that out - https://github.com/manovotn/quarkus/tree/inheritanceRules
from quarkus.
FTR, CDI spec recommends that qualifiers should not declare @Inherited
:
qualifier types should not be declared @inherited,
so that's definitely of minor priority.
As for stereotypes, those would be nice to have feature, but probably not mandatory right away.
It would require deep recursive search through annotations because stereotypes can declare another stereotypes...
from quarkus.
I can confirm that stereotype inheritance doesn't work, as well as transitive stereotypes (stereotype declared on another stereotype). I added some @Disabled
tests for these in a mostly-unrelated PR (#13553).
from quarkus.
so I have start to work on it but I am stuck because jandex seems to not return annotation of superclass got from classInfo.
I am maybe thinking to change completly the code and init all BeanInfo then enriched with qualifer/stereotype inherited
wdyt ? Or there is a solution to
@mkouba
Btw, I copy past the test from @manovotn but I will try to do my own later and add other test.
from quarkus.
CC @Ladicek - is it something doable?
from quarkus.
I am stuck because jandex seems to not return annotation of superclass got from classInfo.
That's intentional and well-documented. You need to walk the class hiearchy instead.
from quarkus.
@mkouba Considering recent developments in CDI Lite and extensions, I think the annotation store in ArC should probably always include all annotations of a class (including inherited ones). This is a little more complicated for scope annotations, and I didn't really think it through yet, so this is more like a heads up than a definitive claim :-)
from quarkus.
I think the annotation store in ArC should probably always include all annotations of a class (including inherited ones)
I assume that you mean the annotations declared on superclasses and annotated with @Inherited
?
from quarkus.
Yes.
from quarkus.
@Ladicek might be worth an issue with some details so we keep track of it?
from quarkus.
At some point, sure. I need to think more about it.
from quarkus.
Related Issues (20)
- how to avoid create temp files when upload file by RESTEasy HOT 2
- Live coding feature not working when shutdown timeout is configured HOT 3
- Getting annotation on intercepted static method returns null HOT 4
- Less user friendly message when have rest and resteasy in one project HOT 7
- [mongodb] devservice executed when host provided HOT 4
- Simplify X-Forwarded-For handling HOT 3
- Make quarkus-security jar names unique so they do not conflict with java auto modules HOT 2
- Cannot inform ArC to instantiate bean in worker thread HOT 2
- Quarkus with Hibernate + panache throws a NoSuchFieldError when using Kotlin HOT 2
- FrameworkRouter not initialized when access-log is enabled with custom non-application-root-path HOT 1
- Hibernate bumps to leads to Hibernate Reactive NPE and Hibernate Validation constraint validation failures where it shouldn't HOT 16
- Better exception when accessing two non-XA datasources in a transaction HOT 11
- @EndpointDisabled can be used on methods HOT 1
- Quarkus 3.10 fails to start if some OIDC providers don't support UserInfo HOT 4
- No database found to handle jdbc:postgresql://.... HOT 4
- Potential NPE thrown from QuarkusClassLoader.getResources HOT 4
- smallrye-reactive-messaging-kafka: Emitter inject in SubscriberDecorator unable to connect emitter error HOT 4
- Build-time configuration values for quarkus.application.name are ignored HOT 2
- gRPC Dev UI bug in 3.10.0 HOT 2
- Quarkus REST should check for `@CustomSerialization` annotations on resource methods returning `Multi`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quarkus.