Coder Social home page Coder Social logo

Comments (6)

gsmet avatar gsmet commented on August 17, 2024 1

While I agree we need a fix in Dekorate, I also think our code in Quarkus is unnecessarily brittle.

I created #40596 to avoid pushing null to the Dekorate method.

@adutra can you check the PR?

from quarkus.

quarkus-bot avatar quarkus-bot commented on August 17, 2024

/cc @geoand (kotlin,kubernetes), @iocanel (kubernetes)

from quarkus.

adutra avatar adutra commented on August 17, 2024

FYI I do have many remotes defined, and one of them is origin.

from quarkus.

geoand avatar geoand commented on August 17, 2024

Thanks for reporting!

Sounds like an easy fix, but it would be in Dekorate, not Quarkus itself

from quarkus.

adutra avatar adutra commented on August 17, 2024

Yes I imagined. That said, on the Quarkus side, we might want to test if scm.getRemote().get("origin") is null... not everyone has a remote called origin ;-)

from quarkus.

geoand avatar geoand commented on August 17, 2024

That sounds like a very specific workaround 😀

from quarkus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.