Coder Social home page Coder Social logo

Comments (25)

phillip-kruger avatar phillip-kruger commented on August 19, 2024 1

I tested this with the latest version and it's fix. Closing here. Please reopen if it's not fixed for you

from quarkus.

1-alex98 avatar 1-alex98 commented on August 19, 2024 1

Thank you so much for all your effort ❤️

from quarkus.

quarkus-bot avatar quarkus-bot commented on August 19, 2024

/cc @MikeEdgar (swagger-ui), @phillip-kruger (swagger-ui)

from quarkus.

1-alex98 avatar 1-alex98 commented on August 19, 2024

I tested it can be easily reproduced with the standard template:

  1. Step one generate a new project with rest easy classic and smallrye-open-api
  2. add to application.properties
    quarkus.swagger-ui.always-include=true
    mp.openapi.scan.disable=true
    quarkus.smallrye-openapi.info-title=Bla
    quarkus.smallrye-openapi.info-contact-email=[email protected]
  3. add openapi,yml in META-INF
  4. open http://localhost:8080/q/swagger-ui/ and see how logo is not displayed

from quarkus.

phillip-kruger avatar phillip-kruger commented on August 19, 2024

Ok, there was a bug a version or so back. Did you try with the latest version?

from quarkus.

1-alex98 avatar 1-alex98 commented on August 19, 2024

I am using the latest version of quarkus excluding RC. Should I try the RC? Otherwise I fear the bug is back.

from quarkus.

phillip-kruger avatar phillip-kruger commented on August 19, 2024

Please try with the RC

from quarkus.

1-alex98 avatar 1-alex98 commented on August 19, 2024

Would like to reopen. I tested 3.8.3. There is does not work for me

from quarkus.

1-alex98 avatar 1-alex98 commented on August 19, 2024

Screenshot_20240320_232333

from quarkus.

phillip-kruger avatar phillip-kruger commented on August 19, 2024

Please test with 3.9 (still CR).

from quarkus.

1-alex98 avatar 1-alex98 commented on August 19, 2024

Screenshot_20240320_234535
well ...

from quarkus.

phillip-kruger avatar phillip-kruger commented on August 19, 2024

Are you sure this is not browser cache ?

from quarkus.

1-alex98 avatar 1-alex98 commented on August 19, 2024

100% not cached by the browser or anything else. Also here is the super easy way on how to reproduce:

Needs to be read upside down :D
Screenshot_20240320_235551
Screenshot_20240320_235527
Screenshot_20240320_235306
Screenshot_20240320_235226
Screenshot_20240320_235141
Screenshot_20240320_235122

from quarkus.

phillip-kruger avatar phillip-kruger commented on August 19, 2024

Do you run in dev mode or prod ? (java -jar)

from quarkus.

1-alex98 avatar 1-alex98 commented on August 19, 2024

dev

2024-03-21 00:00:26,909 INFO  [io.quarkus] (Quarkus Main Thread) logobug 1.0-SNAPSHOT on JVM (powered by Quarkus 3.9.0.CR2) started in 1.580s. Listening on: http://localhost:8080
2024-03-21 00:00:26,912 INFO  [io.quarkus] (Quarkus Main Thread) Profile dev activated. Live Coding activated.
2024-03-21 00:00:26,913 INFO  [io.quarkus] (Quarkus Main Thread) Installed features: [cdi, smallrye-context-propagation, smallrye-openapi, swagger-ui, vertx]

from quarkus.

1-alex98 avatar 1-alex98 commented on August 19, 2024

Content of application.properties can also be empty.

from quarkus.

1-alex98 avatar 1-alex98 commented on August 19, 2024

Run with ./gradlew quarkusDev or with IntelliJ results in the same thing tho

from quarkus.

phillip-kruger avatar phillip-kruger commented on August 19, 2024

Ok, I can not recreate this with a basic mvn app. I can not imagine that this is gradle, but that seems to be the only difference. Can you share a small reproducer ?

from quarkus.

phillip-kruger avatar phillip-kruger commented on August 19, 2024

image

from quarkus.

1-alex98 avatar 1-alex98 commented on August 19, 2024

https://github.com/1-alex98/logobug

from quarkus.

phillip-kruger avatar phillip-kruger commented on August 19, 2024

Thanks, I'll get back to you

from quarkus.

phillip-kruger avatar phillip-kruger commented on August 19, 2024

I can recreate this with your reproducer. The only difference is Gradle (vs maven that I used). I am looking into this, but we might need help from @aloubyansky

from quarkus.

phillip-kruger avatar phillip-kruger commented on August 19, 2024

I have found and fixed this bug, thanks for reporting.

from quarkus.

snazy avatar snazy commented on August 19, 2024

@1-alex98 your path is wrong - must be .../META-INF/branding/logo.png

from quarkus.

phillip-kruger avatar phillip-kruger commented on August 19, 2024

Thanks ! Closing here.

from quarkus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.