Coder Social home page Coder Social logo

Comments (11)

geoand avatar geoand commented on June 27, 2024 1

I removed the dependency in question and as far as I can tell things continue to work...

from quarkus.

geoand avatar geoand commented on June 27, 2024 1

I already have an open PR for it 🙂

from quarkus.

quarkus-bot avatar quarkus-bot commented on June 27, 2024

/cc @FroMage (resteasy-reactive), @geoand (resteasy-reactive), @stuartwdouglas (resteasy-reactive)

from quarkus.

maxandersen avatar maxandersen commented on June 27, 2024

yeah that is not a good thing.

from quarkus.

geoand avatar geoand commented on June 27, 2024

I don't know exactly why quarkus-rest-server-spi-deployment depends on io.quarkus.resteasy.reactive:resteasy-reactive-processor but that's probably something that we need to fix.

Unfortunately this is not really possible as the SPI introduces build items that allow customization of server types.

@phillip-kruger what exactly was the reason you had to depend on quarkus-rest-server-spi-deployment?

from quarkus.

phillip-kruger avatar phillip-kruger commented on June 27, 2024

I'll have a look. I can't remember:)

from quarkus.

phillip-kruger avatar phillip-kruger commented on June 27, 2024

I can not recall why, but definitely not needed, we can just remove that. Just to double check my understanding, that was only depending on a deployment module, so it should not have brought anything into the runtime app of the user ?

from quarkus.

gsmet avatar gsmet commented on June 27, 2024

Yes as I Said, it was only in the deployment classpath.
I noticed it because I built an app that is not using RR and when I updated Quarkus, it downloaded the RR jar.

Nice if we can drop it.

from quarkus.

phillip-kruger avatar phillip-kruger commented on June 27, 2024

Ok great, I just wanted to make sure my understanding is correct. I'll prepare a pr to remove it

from quarkus.

phillip-kruger avatar phillip-kruger commented on June 27, 2024

Sorry - i did not see :) I'll close mine.

from quarkus.

geoand avatar geoand commented on June 27, 2024

NP!

from quarkus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.