Build Card Page for Dev UI results in NPE in ArtifactInfoUtil about quarkus

[phillip-kruger]

Let me have a look and get back to you

[quarkus-bot]

/cc @cescoffier (devui), @phillip-kruger (devui)

[phillip-kruger]

@Dudeplayz Do you have a reproducer I can look at ?

[Dudeplayz]

@phillip-kruger I think the issue is another. We created a deployment-common package where the code rests.
So this line

quarkus/core/deployment/src/main/java/io/quarkus/deployment/util/ArtifactInfoUtil.java

Line 128 in 885cb8a

if (deployment == null || !deployment.getFileName().toString().equals("deployment")) {

fails for us, where our path is: /Users/.../deployment-commons/target/classes.

[Dudeplayz]

@Dudeplayz Do you have a reproducer I can look at ?

I tired to add the Dev UI here: https://github.com/mcollovati/quarkus-hilla/tree/main/deployment-commons/src/main/java/com/github/mcollovati/quarkus/hilla/deployment

The Dev UI processor is above. I don't have an explicit reproducer by now. But I think it relates to the different package naming I mentioned above. I can create one if still needed?

[phillip-kruger]

Ok, if you can share something that reproduce this I can see if it's possible to accommodate that structure. But if you can change to use the default structure we can probably close here

[Dudeplayz]

We will discuss it. Is this restriction/behavior documented somewhere? Maybe just check if it begins or contains the deployment phrase instead of equality?

[Dudeplayz]

But maybe some catching of the null returning root path or more meaningful error message would be helpful there too.

[phillip-kruger]

I think the way we have done it in Quarkus, is to move common stuff a separate extension. Example: electon security: https://github.com/quarkusio/quarkus/tree/main/extensions

elytron-security-common
elytron-security-jdbc
elytron-security-ldap
elytron-security-oauth2
elytron-security-properties-file
elytron-security

So a user will add one of the extensions, example elytron-security-oauth2 and that will pull in the elytron-security-common extension.

Doing it this way should allow you to put the common Dev UI in the common extension