Coder Social home page Coder Social logo

Comments (4)

quarkus-bot avatar quarkus-bot commented on July 19, 2024

/cc @Ladicek (arc), @manovotn (arc), @mkouba (arc)

from quarkus.

manovotn avatar manovotn commented on July 19, 2024

This should work and is likely a bug in the respective processor (https://github.com/quarkusio/quarkus/blob/main/extensions/smallrye-context-propagation/deployment/src/main/java/io/quarkus/smallrye/context/deployment/SmallRyeContextPropagationProcessor.java).
I'll take a look on Mon.

from quarkus.

manovotn avatar manovotn commented on July 19, 2024

Hm, the processor here assumes that it operates on an AnnotationTarget that's METHOD_PARAMETER but instead, Arc gives it the whole METHOD. This doesn't seem very useful as you cannot really modify qualifiers of each method parameter which is what we'd need here.

Furthermore, this isn't the only place where we make such assumption, another processor doing the same is grpc processor and I'd assume this will also never work.

The Arc code seems very deliberate in not handling method parameters and it looks like something we encountered while integrating CDI BC extensions as well.

from quarkus.

manovotn avatar manovotn commented on July 19, 2024

I have a WIP draft fixing this in my branch but I need to take a closer look on Mon and polish it a little.
Plus it looks like there are other pieces of code that might be using the IP transformer incorrectly which I'd like to double check as well.

from quarkus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.