Coder Social home page Coder Social logo

Comments (4)

emmanuelbernard avatar emmanuelbernard commented on August 15, 2024 2

@ia3andy for the sake of velocity, I think you should create it in the launcher.

Since @aloubyansky and all are working on a gradle add-extension based on an include in the build.gradle, we could sue the opportunity of that being done to then have a "gradle create" and rethink that choice. At this time we will add gradle support in the launcher too.

from code.quarkus.io.

ia3andy avatar ia3andy commented on August 15, 2024

Here is the discussion we had in Zulip on June 25 2019 with @geoand & @gsmet:

Andy Damevin: I noticed when using the Quarkus project generator that the generated project does not contain mvnw. I think, all the guides are relying on mvnw beeing there right?

Georgios Andrianakis: weird, using mvn ... create ... should produce the maven wrapper. I always works for me

Andy Damevin: I mean using the library

Georgios Andrianakis: oh, OK. yeah, the wrapper is added in the mojo

Guillaume Smet: The library is not tied to Maven. That’s why it’s done in the Mojo. Not sure if we could change that without breaking modularity.

Andy Damevin: .buildTool(BuildTool.MAVEN)

Georgios Andrianakis: the wrapper itself is generated by a different maven plugin. it could of course exist in the project and just be copied, but the way it's done now makes most sense I think when taking into account how projects are created

Guillaume Smet: Including it in the template could be an option. But it would be harder to maintain for us. Except if it could be installed automatically in the template during the build maybe.

Georgios Andrianakis: Can't the launcher include it?

Andy Damevin: of course we could, is it the best solution, I am not sure

Guillaume Smet: We require a recent version and we had reports of people using old ones until we switched to mvnw

Andy Damevin: Who is supposed to use the java Quarkus build tool? It would be weird IMO, to add some logic that couldn't be used by any consumer of this library

from code.quarkus.io.

ia3andy avatar ia3andy commented on August 15, 2024

@stuartwdouglas Here is the issue for the missing mvnw. @emmanuelbernard @gsmet, we need to decide how we handle this.

from code.quarkus.io.

emmanuelbernard avatar emmanuelbernard commented on August 15, 2024

Created #67

from code.quarkus.io.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.