Comments (14)
I don't think we want that, at least not in the long term. What was wrong perhaps is that a micro release (1.0.7) of this project suddenly started requiring Jandex 2.4.3 where it was previously fine with 2.4.2. That perhaps should have been a minor release (1.1.0). So I guess I'd be fine with merging the PR for one more 1.0.x release and then do a 1.1.0 that requires Jandex 2.4.3 or 3.0+.
from quarkus-reactive-messaging-http.
@ricardozanini OK, here's my suggestion:
- Revert #92 or merge #96, both are fine IMHO.
- Release 1.0.8.
- Create a
1.0.x
branch from the post-release commit. - Apply #92 again on the
main
branch. - Release 1.1.0.
Makes sense?
from quarkus-reactive-messaging-http.
@Ladicek @cescoffier that sounds good to me. I'll have a meeting now, but I'll do it after that.
from quarkus-reactive-messaging-http.
Released 1.0.8, cherry-pick #92 in #98
I'll do a 1.1.0 release and update the release notes after we merge it.
from quarkus-reactive-messaging-http.
Jandex version 3 will be available in the next Quarkus release ( 2.13 )
No, Jandex 3 is for 2.14. 2.13 is still on Jandex 2.
I know @Ladicek added several things to 2.4.3 to make the migration smoother, i will let him comment on this.
from quarkus-reactive-messaging-http.
Suggested migration steps are described in depth in https://smallrye.io/blog/jandex-3-0-0/
Specifically for MethodInfo.parameters()
, there's unfortunately no way to support Jandex versions 2.4.2 and before together with Jandex 3.0.0 and above. The replacement is MethodInfo.parameterTypes()
, which is available since Jandex 2.4.3.
from quarkus-reactive-messaging-http.
there's unfortunately no way
Actually the PR you sent has a way. I didn't consider args()
, because that method has been deprecated for a long time.
from quarkus-reactive-messaging-http.
@gsmet sorry, mentioned the wrong version, it's in Quarkus main, that's why we see that in Kogito
@Ladicek yeah, endup doing the same in Kogito, was the only way I found to keep it backwards compatible.
Let me know if you need anything else in the PR. We would need a new build whenever possible as this is one the issues blocking quarkusio/quarkus#12486
from quarkus-reactive-messaging-http.
@Ladicek that seems reasonable. In Kogito we do require to align with Quarkus 2.7 for a while, so in that case, if we need any fix, we could do another micro.
@fjtirado @ricardozanini fyi
from quarkus-reactive-messaging-http.
Hi @cescoffier, WDYT about my suggestion above? I don't have maintainer permissions on this project, but the Quarkiverse release process is so similar to SmallRye's, I think I'd be able to handle it myself, if you agree. (And if I get the permissions :-) )
from quarkus-reactive-messaging-http.
I don't think we want that, at least not in the long term. What was wrong perhaps is that a micro release (1.0.7) of this project suddenly started requiring Jandex 2.4.3 where it was previously fine with 2.4.2. That perhaps should have been a minor release (1.1.0). So I guess I'd be fine with merging the PR for one more 1.0.x release and then do a 1.1.0 that requires Jandex 2.4.3 or 3.0+.
@Ladicek we upgraded a patch version with a patch version. We can revert that change in a minor and release 1.1.x with 2.4.3.
from quarkus-reactive-messaging-http.
Hi @cescoffier, WDYT about my suggestion above? I don't have maintainer permissions on this project, but the Quarkiverse release process is so similar to SmallRye's, I think I'd be able to handle it myself, if you agree. (And if I get the permissions :-) )
I have the permissions, just let me know what you need and we can go ahead and do it.
from quarkus-reactive-messaging-http.
Sorry, catching up.
So, we have a breakage?
If so, we should revert and re-release a micro (patch).
Then, we should update (re-apply the update) and release a minor version.
I'm full of meeting this afternoon, but I can have a look tonight. Just let me know.
from quarkus-reactive-messaging-http.
Thanks @cescoffier, I forgot @ricardozanini is a maintainer too. We'll sort it out, thanks!
from quarkus-reactive-messaging-http.
Related Issues (18)
- How can I set Connection Timeout & Read Timeout ?
- Add support to Quarkus 3
- Upgrade release.yml to using Environment Files. HOT 2
- List configuration properties on the pages
- ce_time header is not following RFC-3339 when seconds are 0 HOT 4
- All contributors HOT 2
- Enhanchement request : Support multiple outgoing urls
- move native test from quarkus core repository HOT 1
- move quickstart and guide from quarkusio org HOT 1
- "Unable to find matching target resource method" in native mode for incoming channel HOT 1
- provide support for broadcast on incoming channel HOT 1
- move issues from quarkus core repo and remove the extension there HOT 6
- Reactive Messaging WebSockets connector - exception thrown on close
- Reactive HTTP and WebSocket connector enhancements
- Use -DnoCode instead of -DnoExamples and add resteasy-reactive extension in the guides HOT 1
- Support binary form of Cloud Events HOT 9
- HTTP and CloudEvent headers cannot be set outgoing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from quarkus-reactive-messaging-http.