Incompatibility in Jandex version 3 and 2.x about quarkus-reactive-messaging-http

[Ladicek]

I don't think we want that, at least not in the long term. What was wrong perhaps is that a micro release (1.0.7) of this project suddenly started requiring Jandex 2.4.3 where it was previously fine with 2.4.2. That perhaps should have been a minor release (1.1.0). So I guess I'd be fine with merging the PR for one more 1.0.x release and then do a 1.1.0 that requires Jandex 2.4.3 or 3.0+.

[Ladicek]

@ricardozanini OK, here's my suggestion:

1. Revert #92 or merge #96, both are fine IMHO.
2. Release 1.0.8.
3. Create a 1.0.x branch from the post-release commit.
4. Apply #92 again on the main branch.
5. Release 1.1.0.

Makes sense?

[ricardozanini]

@Ladicek @cescoffier that sounds good to me. I'll have a meeting now, but I'll do it after that.

[ricardozanini]

Released 1.0.8, cherry-pick #92 in #98

I'll do a 1.1.0 release and update the release notes after we merge it.

[gsmet]

Jandex version 3 will be available in the next Quarkus release ( 2.13 )

No, Jandex 3 is for 2.14. 2.13 is still on Jandex 2.
I know @Ladicek added several things to 2.4.3 to make the migration smoother, i will let him comment on this.

[Ladicek]

Suggested migration steps are described in depth in https://smallrye.io/blog/jandex-3-0-0/

Specifically for MethodInfo.parameters(), there's unfortunately no way to support Jandex versions 2.4.2 and before together with Jandex 3.0.0 and above. The replacement is MethodInfo.parameterTypes(), which is available since Jandex 2.4.3.

[Ladicek]

there's unfortunately no way

Actually the PR you sent has a way. I didn't consider args(), because that method has been deprecated for a long time.

[cristianonicolai]

@gsmet sorry, mentioned the wrong version, it's in Quarkus main, that's why we see that in Kogito
@Ladicek yeah, endup doing the same in Kogito, was the only way I found to keep it backwards compatible.
Let me know if you need anything else in the PR. We would need a new build whenever possible as this is one the issues blocking quarkusio/quarkus#12486

[cristianonicolai]

@Ladicek that seems reasonable. In Kogito we do require to align with Quarkus 2.7 for a while, so in that case, if we need any fix, we could do another micro.
@fjtirado @ricardozanini fyi

[Ladicek]

Hi @cescoffier, WDYT about my suggestion above? I don't have maintainer permissions on this project, but the Quarkiverse release process is so similar to SmallRye's, I think I'd be able to handle it myself, if you agree. (And if I get the permissions :-) )

[ricardozanini]

I don't think we want that, at least not in the long term. What was wrong perhaps is that a micro release (1.0.7) of this project suddenly started requiring Jandex 2.4.3 where it was previously fine with 2.4.2. That perhaps should have been a minor release (1.1.0). So I guess I'd be fine with merging the PR for one more 1.0.x release and then do a 1.1.0 that requires Jandex 2.4.3 or 3.0+.

@Ladicek we upgraded a patch version with a patch version. We can revert that change in a minor and release 1.1.x with 2.4.3.

[ricardozanini]

Hi @cescoffier, WDYT about my suggestion above? I don't have maintainer permissions on this project, but the Quarkiverse release process is so similar to SmallRye's, I think I'd be able to handle it myself, if you agree. (And if I get the permissions :-) )

I have the permissions, just let me know what you need and we can go ahead and do it.

[cescoffier]

Sorry, catching up.
So, we have a breakage?

If so, we should revert and re-release a micro (patch).
Then, we should update (re-apply the update) and release a minor version.

I'm full of meeting this afternoon, but I can have a look tonight. Just let me know.

[Ladicek]

Thanks @cescoffier, I forgot @ricardozanini is a maintainer too. We'll sort it out, thanks!