version 3.0.0 no longer works because of missing javascript files about quarkus-logging-manager

[garyhodgson]

I won't be able to produce a PR for this, the diff was just a FYI.

[phillip-kruger]

What version of Quarkus are you using ?

[lfarkas]

3.2.3.Final

[phillip-kruger]

Ok, it will not work with latest, but we can fix that. Are you using the ui ? Or the REST endpoints ?

[lfarkas]

the web ui

[garyhodgson]

Hi. it seems with the new dev ui, the javascript and css files are moved or perhaps no longer there. They are still available via the "q/dev-v1" URL, but this is of cource now deprecated. Still, the following diff got the extension working for me in the meantime:

diff --git deployment/src/main/java/io/quarkiverse/loggingmanager/deployment/LoggingManagerProcessor.java deployment/src/main/java/io/quarkiverse/loggingmanager/deployment/LoggingManagerProcessor.java
index 83a9647..fc5d648 100644
--- deployment/src/main/java/io/quarkiverse/loggingmanager/deployment/LoggingManagerProcessor.java
+++ deployment/src/main/java/io/quarkiverse/loggingmanager/deployment/LoggingManagerProcessor.java
@@ -161,7 +161,7 @@ class LoggingManagerProcessor {
                 Files.createFile(indexHtml);
             }
             String indexHtmlContent = getIndexHtmlContents(nonApplicationRootPathBuildItem.getNonApplicationRootPath(),
-                    "/dev/logstream");
+                    "/dev-v1/logstream");

             Files.write(indexHtml, indexHtmlContent.getBytes());

@@ -187,7 +187,7 @@ class LoggingManagerProcessor {
             String indexHtmlContent = getIndexHtmlContents(nonApplicationRootPathBuildItem.getNonApplicationRootPath(),
                     "/" + loggingManagerConfig.basePath + "/logstream");
             // Update the resource Url to be relative
-            String pathToBeReplaced = nonApplicationRootPathBuildItem.resolvePath("dev/resources");
+            String pathToBeReplaced = nonApplicationRootPathBuildItem.resolvePath("dev-v1/resources");
             indexHtmlContent = indexHtmlContent.replaceAll(pathToBeReplaced + "/", "");
             String indexHtmlFileName = UI_FINAL_DESTINATION + "/" + INDEX_HTML;
             generatedResourceProducer.produce(new GeneratedResourceBuildItem(indexHtmlFileName, indexHtmlContent.getBytes()));
@@ -305,7 +305,7 @@ class LoggingManagerProcessor {
                         cleanFrameworkRootPath(nonApplicationRootPath));

                 indexHtmlContent = indexHtmlContent.replaceAll("\\{devRootAppend}",
-                        cleanFrameworkRootPath(nonApplicationRootPath) + "/dev");
+                        cleanFrameworkRootPath(nonApplicationRootPath) + "/dev-v1");

                 indexHtmlContent = indexHtmlContent.replaceAll("\\{streamingPath}",
                         streamingPath);
diff --git deployment/src/main/resources/META-INF/resources/template/loggermanager.html deployment/src/main/resources/META-INF/resources/template/loggermanager.html
index 4bd21d0..41d64b2 100644
--- deployment/src/main/resources/META-INF/resources/template/loggermanager.html
+++ deployment/src/main/resources/META-INF/resources/template/loggermanager.html
@@ -6,11 +6,11 @@
         <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">

         <!-- Bootstrap CSS -->
-        <link rel="stylesheet" href="{frameworkRootPath}/dev/resources/css/bootstrap.min.css">
-        <link rel="stylesheet" href="{frameworkRootPath}/dev/resources/fontawesome/css/all.min.css">
-        <link rel="stylesheet" href="{frameworkRootPath}/dev/resources/css/logstream.css">
+        <link rel="stylesheet" href="{frameworkRootPath}/dev-v1/resources/css/bootstrap.min.css">
+        <link rel="stylesheet" href="{frameworkRootPath}/dev-v1/resources/fontawesome/css/all.min.css">
+        <link rel="stylesheet" href="{frameworkRootPath}/dev-v1/resources/css/logstream.css">

-        <link rel="shortcut icon" type="image/png" href="{frameworkRootPath}/dev/resources/images/favicon.ico" >
+        <link rel="shortcut icon" type="image/png" href="{frameworkRootPath}/dev-v1/resources/images/favicon.ico" >

         <title>Logging manager | {applicationName} {applicationVersion}</title>

@@ -52,9 +52,9 @@
         {logContent}
         {modalsContent}

-        <script src="{frameworkRootPath}/dev/resources/js/jquery.min.js"></script>
-        <script src="{frameworkRootPath}/dev/resources/js/bootstrap.bundle.min.js"></script>
-        <script src="{frameworkRootPath}/dev/resources/js/logstream.js"
+        <script src="{frameworkRootPath}/dev-v1/resources/js/jquery.min.js"></script>
+        <script src="{frameworkRootPath}/dev-v1/resources/js/bootstrap.bundle.min.js"></script>
+        <script src="{frameworkRootPath}/dev-v1/resources/js/logstream.js"
                 data-frameworkRootPath="{frameworkRootPath}"
                 data-showOnStart="true"
                 data-streamingPath="{streamingPath}">

[lfarkas]

may be a bugfix release would be useful...

[lfarkas]

and probably a now so hardcoded path would be even better. eg: put into a constant...

[phillip-kruger]

Do you want to do a PR with your diff?

[lfarkas]

i don't know the codebase what's more don't know what's not working now...
i'm just see the above diff and normally i use not allow such code into our codebase...it's against some basic clean coding guideline...

[phillip-kruger]

We can do a bugfix for the current 3.x, but the next 3.x the old dev ui will be removed. Then we need a big fix here.